Skip to content

Commit 2b10c89

Browse files
committed
Reenable test
1 parent 3d60871 commit 2b10c89

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

l1-contracts/test/validator-selection/ValidatorSelection.t.sol

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ contract ValidatorSelectionTest is ValidatorSelectionTestBase {
8181
});
8282

8383
bytes4 NO_REVERT = bytes4(0);
84+
bytes4 ANY_REVERT = bytes4(0xFFFFFFFF);
8485

8586
function testInitialCommitteeMatch() public setup(4, 4) progressEpochs(2) {
8687
address[] memory attesters = rollup.getAttesters();
@@ -381,17 +382,14 @@ contract ValidatorSelectionTest is ValidatorSelectionTestBase {
381382
// a block if you submit one with no signatures. This was a change from prior behavior where we had had
382383
// that if there were zero validators in a rollup, anyone could build a block
383384

384-
// TODO(palla): What should we do in this scenario? Block the proposal, or allow invalidating later?
385-
vm.skip(true);
386-
387385
GSE gse = rollup.getGSE();
388386
address caller = gse.owner();
389387
vm.prank(caller);
390388
gse.addRollup(address(0xdead));
391389
assertEq(rollup.getCurrentEpochCommittee().length, 4);
392390
_testBlock(
393391
"mixed_block_1",
394-
NO_REVERT,
392+
ANY_REVERT,
395393
0,
396394
0,
397395
TestFlags({
@@ -543,7 +541,11 @@ contract ValidatorSelectionTest is ValidatorSelectionTestBase {
543541

544542
emit log("Time to propose");
545543
if (_revertData != NO_REVERT) {
546-
vm.expectPartialRevert(_revertData);
544+
if (_revertData == ANY_REVERT) {
545+
vm.expectRevert();
546+
} else {
547+
vm.expectPartialRevert(_revertData);
548+
}
547549
}
548550

549551
vm.prank(ree.sender);

0 commit comments

Comments
 (0)