Simplified user constructor not exposing uneeded properties for domain

Author: benatespina

spec/BenGor/User/Domain/Event/UserRememberPasswordRequestedMailerSubscriberSpec.php

@@ -55,19 +55,15 @@ function it_implements_domain_event_subscriber()
 
     function it_handles(UserUrlGenerator $urlGenerator, UserMailableFactory $mailableFactory)
     {
-        $domainEvent = new UserRememberPasswordRequested(
-            new User(
-                new UserId(),
-                new UserEmail('bengor@user.com'),
-                UserPassword::fromEncoded('endoced-password', 'salt'),
-                [new UserRole('ROLE_USER')],
-                null,
-                null,
-                null,
-                null,
-                new UserToken()
-            )
+        $user = new User(
+            new UserId(),
+            new UserEmail('bengor@user.com'),
+            UserPassword::fromEncoded('endoced-password', 'salt'),
+            [new UserRole('ROLE_USER')]
         );
+        $user->rememberPassword();
+
+        $domainEvent = new UserRememberPasswordRequested($user);
         $mailable = new UserMailable(
             new UserEmail('benatespina@gmail.com'),
             new UserEmail('bengor@user.com'),

src/BenGor/User/Domain/Model/User.php

@@ -100,35 +100,19 @@ class User
     /**
      * Constructor.
      *
-     * @param UserId                  $anId                   The id
-     * @param UserEmail               $anEmail                The email
-     * @param UserPassword            $aPassword              The encoded password
-     * @param array                   $userRoles              Array which contains the roles
-     * @param \DateTimeInterface|null $aCreatedOn             The created on
-     * @param \DateTimeInterface|null $anUpdatedOn            The updated on
-     * @param \DateTimeInterface|null $aLastLogin             The last login
-     * @param UserToken|null          $aConfirmationToken     The confirmation token
-     * @param UserToken|null          $aRememberPasswordToken The remember me token
+     * @param UserId       $anId      The id
+     * @param UserEmail    $anEmail   The email
+     * @param UserPassword $aPassword The encoded password
+     * @param array        $userRoles Array which contains the roles
      */
-    public function __construct(
-        UserId $anId,
-        UserEmail $anEmail,
-        UserPassword $aPassword,
-        array $userRoles,
-        \DateTimeInterface $aCreatedOn = null,
-        \DateTimeInterface $anUpdatedOn = null,
-        \DateTimeInterface $aLastLogin = null,
-        UserToken $aConfirmationToken = null,
-        UserToken $aRememberPasswordToken = null
-    ) {
+    public function __construct(UserId $anId, UserEmail $anEmail, UserPassword $aPassword, array $userRoles)
+    {
         $this->id = $anId;
         $this->email = $anEmail;
         $this->password = $aPassword;
-        $this->confirmationToken = $aConfirmationToken ?: new UserToken();
-        $this->createdOn = $aCreatedOn ?: new \DateTimeImmutable();
-        $this->updatedOn = $anUpdatedOn ?: new \DateTimeImmutable();
-        $this->lastLogin = $aLastLogin ?: null;
-        $this->rememberPasswordToken = $aRememberPasswordToken;
+        $this->confirmationToken = new UserToken();
+        $this->createdOn = new \DateTimeImmutable();
+        $this->updatedOn = new \DateTimeImmutable();
 
         $this->roles = [];
         foreach ($userRoles as $userRole) {

src/BenGor/User/Infrastructure/Persistence/Sql/SqlUserRepository.php

@@ -163,7 +163,7 @@ private function exist(User $aUser)
             'SELECT COUNT(*) FROM user WHERE id = :id', [':id' => $aUser->id()->id()]
         )->fetchColumn();
 
-        return (int) $count === 1;
+        return (int)$count === 1;
     }
 
     /**
@@ -262,6 +262,8 @@ private function execute($aSql, array $parameters)
      */
     private function buildUser($row)
     {
+        $createdOn = new \DateTimeImmutable($row['created_on']);
+        $updatedOn = new \DateTimeImmutable($row['updated_on']);
         $lastLogin = null === $row['last_login']
             ? null
             : new \DateTimeImmutable($row['last_login']);
@@ -272,17 +274,20 @@ private function buildUser($row)
             ? null
             : new UserToken($row['remember_password_token']);
 
-        return new User(
+        $user = new User(
             new UserId($row['id']),
             new UserEmail($row['email']),
             UserPassword::fromEncoded($row['password'], $row['salt']),
-            $this->rolesToArray($row['roles']),
-            new \DateTimeImmutable($row['created_on']),
-            new \DateTimeImmutable($row['updated_on']),
-            $lastLogin,
-            $confirmationToken,
-            $rememberPasswordToken
+            $this->rolesToArray($row['roles'])
         );
+
+        $user = $this->set($user, 'createdOn', $createdOn);
+        $user = $this->set($user, 'updatedOn', $updatedOn);
+        $user = $this->set($user, 'lastLogin', $lastLogin);
+        $user = $this->set($user, 'confirmationToken', $confirmationToken);
+        $user = $this->set($user, 'rememberPasswordToken', $rememberPasswordToken);
+
+        return $user;
     }
 
     /**
@@ -314,4 +319,24 @@ private function rolesToArray($userRoles)
             return new UserRole($userRole);
         }, json_decode($userRoles));
     }
+
+    /**
+     * Populates by Reflection the domain object with the given SQL plain values.
+     *
+     * @param User   $user          The user domain object
+     * @param string $propertyName  The property name
+     * @param mixed  $propertyValue The property value
+     *
+     * @return User
+     */
+    private function set(User $user, $propertyName, $propertyValue)
+    {
+        $reflectionUser = new \ReflectionClass($user);
+
+        $reflectionCreatedOn = $reflectionUser->getProperty($propertyName);
+        $reflectionCreatedOn->setAccessible(true);
+        $reflectionCreatedOn->setValue($user, $propertyValue);
+
+        return $user;
+    }
 }