GameList: Address review feedback - rename SetGameFavorite to SaveFavoriteForPath and remove unused getter

Author: Vishrut2403

pcsx2-qt/GameList/GameListWidget.cpp

@@ -200,8 +200,7 @@ namespace
 			}
 
 			// Draw star overlay on bottom-right corner if game is favorited.
-			const bool is_favorite = (index.column() == GameListModel::Column_Cover) &&
-				index.data(GameListModel::NeedsFavoriteBadgeRole).toBool();
+			const bool is_favorite = index.data(GameListModel::NeedsFavoriteBadgeRole).toBool();
 			if (is_favorite)
 			{
 				const auto* sort_model = static_cast<const QSortFilterProxyModel*>(index.model());

pcsx2-qt/MainWindow.cpp

@@ -1556,7 +1556,7 @@ void MainWindow::onGameListEntryContextMenuRequested(const QPoint& point)
 		const bool is_favorite = entry->is_favorite;
 		action = menu.addAction(is_favorite ? tr("Remove from Favorites") : tr("Add to Favorites"));
 		connect(action, &QAction::triggered, [this, entry]() {
-			GameList::SetGameFavorite(entry->path, !entry->is_favorite);
+			GameList::SaveFavoriteForPath(entry->path, !entry->is_favorite);
 			m_game_list_widget->refresh(false, false);
 		});
 

pcsx2/GameList.cpp

@@ -1462,39 +1462,6 @@ std::string GameList::GetCustomPropertiesFile()
 	return Path::Combine(EmuFolders::Settings, "custom_properties.ini");
 }
 
-bool GameList::IsGameFavorited(const std::string& path)
-{
-	std::unique_lock lock(s_mutex);
-	const GameList::Entry* entry = GetEntryForPath(path.c_str());
-	if (entry)
-		return entry->is_favorite;
-
-	return false;
-}
-
-void GameList::SetGameFavorite(const std::string& path, bool favorite)
-{
-	INISettingsInterface custom_attributes(GetCustomPropertiesFile());
-	custom_attributes.Load();
-
-	if (favorite)
-	{
-		custom_attributes.SetBoolValue(path.c_str(), "Favorited", true);
-	}
-	else
-	{
-		custom_attributes.DeleteValue(path.c_str(), "Favorited");
-	}
-
-	if (custom_attributes.Save())
-	{
-		std::unique_lock lock(s_mutex);
-		GameList::Entry* entry = const_cast<GameList::Entry*>(GetEntryForPath(path.c_str()));
-		if (entry)
-			entry->is_favorite = favorite;
-	}
-}
-
 void GameList::CheckCustomAttributesForPath(const std::string& path, bool& has_custom_title, bool& has_custom_region)
 {
 	INISettingsInterface names(GetCustomPropertiesFile());
@@ -1547,6 +1514,29 @@ void GameList::SaveCustomRegionForPath(const std::string& path, int custom_regio
 	}
 }
 
+void GameList::SaveFavoriteForPath(const std::string& path, bool favorite)
+{
+	INISettingsInterface custom_attributes(GetCustomPropertiesFile());
+	custom_attributes.Load();
+
+	if (favorite)
+	{
+		custom_attributes.SetBoolValue(path.c_str(), "Favorited", true);
+	}
+	else
+	{
+		custom_attributes.DeleteValue(path.c_str(), "Favorited");
+	}
+
+	if (custom_attributes.Save())
+	{
+		std::unique_lock lock(s_mutex);
+		GameList::Entry* entry = const_cast<GameList::Entry*>(GetEntryForPath(path.c_str()));
+		if (entry)
+			entry->is_favorite = favorite;
+	}
+}
+
 std::string GameList::GetCustomTitleForPath(const std::string& path)
 {
 	std::string ret;

pcsx2/GameList.h

@@ -158,10 +158,9 @@ namespace GameList
 		std::function<void(const Entry*, std::string)> save_callback = {});
 
 	// Custom properties support
-	bool IsGameFavorited(const std::string& path);
-	void SetGameFavorite(const std::string& path, bool favorite);
 	void CheckCustomAttributesForPath(const std::string& path, bool& has_custom_title, bool& has_custom_region);
 	void SaveCustomTitleForPath(const std::string& path, const std::string& custom_title);
 	void SaveCustomRegionForPath(const std::string& path, int custom_region);
+	void SaveFavoriteForPath(const std::string& path, bool favorite);
 	std::string GetCustomTitleForPath(const std::string& path);
 } // namespace GameList