Qt: Fix crash when closing OSD font picker dialog

chaoticgd · F0bes · commit c186f8d3666c · 2026-04-28T12:09:23.000-04:00
diff --git a/pcsx2-qt/Settings/OSDSettingsWidget.cpp b/pcsx2-qt/Settings/OSDSettingsWidget.cpp
@@ -184,10 +184,6 @@ void OSDSettingsWidget::onBrowseOsdFontPathClicked()
 		saveOsdFontPathSetting(QDir::toNativeSeparators(selected));
 	});
 
-	connect(m_font_picker, &QObject::destroyed, this, [this]() {
-		m_font_picker = nullptr;
-	});
-
 	m_font_picker->show();
 }
 
@@ -313,4 +309,4 @@ void OSDSettingsWidget::onDeselectAllClicked()
 	m_ui.warnAboutUnsafeSettings->setChecked(true);
 }
 
-#include "moc_OSDSettingsWidget.cpp"
+#include "moc_OSDSettingsWidget.cpp"

Original file line number	Diff line number	Diff line change
`@@ -184,10 +184,6 @@ void OSDSettingsWidget::onBrowseOsdFontPathClicked()`
`184`	`184`	`saveOsdFontPathSetting(QDir::toNativeSeparators(selected));`
`185`	`185`	`});`
`186`	`186`
`187`		`- connect(m_font_picker, &QObject::destroyed, this, [this]() {`
`188`		`- m_font_picker = nullptr;`
`189`		`- });`
`190`		`-`
`191`	`187`	`m_font_picker->show();`
`192`	`188`	`}`
`193`	`189`
`@@ -313,4 +309,4 @@ void OSDSettingsWidget::onDeselectAllClicked()`
`313`	`309`	`m_ui.warnAboutUnsafeSettings->setChecked(true);`
`314`	`310`	`}`
`315`	`311`
`316`		`-#include "moc_OSDSettingsWidget.cpp"`
	`312`	`+#include "moc_OSDSettingsWidget.cpp"`