Merge pull request #24 from Sage/build-ruby3

Fix kwargs usage for Ruby 3 compatibility

Author: guille-sage

.github/workflows/test.yml

@@ -6,11 +6,16 @@ jobs:
   test:
     runs-on: ubuntu-latest
 
+    strategy:
+      matrix:
+        ruby: ['2.7', '3.2']
+
     steps:
       - uses: actions/checkout@v2
-      - uses: ruby/[email protected]
+      - name: Set up Ruby ${{ matrix.ruby }}
+        uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.4
+          ruby-version: ${{ matrix.ruby }}
           bundler: 1
           bundler-cache: true
         env:

Dockerfile

@@ -1,10 +1,12 @@
-FROM ruby:2.3-alpine
+FROM ruby:3.2-alpine
 
 RUN apk add --no-cache --update bash
 
+COPY Gemfile elastic_search_framework.gemspec .
+COPY lib/elastic_search_framework/version.rb ./lib/elastic_search_framework/
+
 RUN apk add --no-cache --update --virtual .gem-builddeps make gcc libc-dev ruby-json \
-    && gem install -N oj -v 2.15.0 \
-    && gem install -N json -v 2.1.0 \
+    && bundle \
     && apk del .gem-builddeps
 
 # Create application directory and set it as the WORKDIR.

Gemfile

@@ -1,6 +1,6 @@
 source 'https://rubygems.org'
 
-gem 'json', '2.1.0'
+gem 'json'
 
 # Specify your gem's dependencies in elastic_search_framework.gemspec
 gemspec

README.md

@@ -21,7 +21,7 @@ Or install it yourself as:
 ## Usage
 
 
-##Global Config
+## Global Config
 
 ### #namespace
 The namespace is used to set the prefix applied to all table and index names.
@@ -241,26 +241,23 @@ To run the tests locally, we use Docker to provide both a Ruby and JRuby environ
 > This builds the Ruby docker image.
 
 ```bash
-cd script
-./setup.sh
+./script/setup.sh
 ```
 
 ### Run Tests:
 
 > This executes the test suite.
 
 ```bash
-cd script
-./test.sh
+./script/test.sh
 ```
 
 ### Cleanup
 
 > This is used to clean down docker image created in the setup script.
 
 ```bash
-cd script
-./cleanup.sh
+./script/cleanup.sh
 ```
 
 ## Development

script/docker-compose.yml renamed to docker-compose.yml

@@ -18,4 +18,4 @@ services:
     depends_on:
       - elasticsearch
     volumes:
-      - ../:/elastic_search_framework
+      - ./:/elastic_search_framework

elastic_search_framework.gemspec

@@ -19,10 +19,11 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency 'bundler', '~> 1.11'
+  spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'pry-byebug'
   spec.add_dependency 'hash_kit', '~> 0.5'
   spec.add_dependency 'json'
   spec.add_dependency 'connection_pool'

lib/elastic_search_framework/index.rb

@@ -176,21 +176,21 @@ def get_item(id:, type: 'default', routing_key: nil)
       options = { index: self, id: id, type: type }
       options[:routing_key] = routing_key if routing_enabled? && routing_key
 
-      repository.get(options)
+      repository.get(**options)
     end
 
     def put_item(type: 'default', item:, op_type: 'index', routing_key: nil)
       options = { entity: item, index: self, type: type, op_type: op_type }
       options[:routing_key] = routing_key if routing_enabled? && routing_key
 
-      repository.set(options)
+      repository.set(**options)
     end
 
     def delete_item(id:, type: 'default', routing_key: nil)
       options = { index: self, id: id, type: type }
       options[:routing_key] = routing_key if routing_enabled? && routing_key
 
-      repository.drop(options)
+      repository.drop(**options)
     end
 
     def query

lib/elastic_search_framework/index_alias.rb

@@ -129,15 +129,15 @@ def get_item(id:, type: "default", routing_key: nil)
       options = { index: self, id: id, type: type }
       options[:routing_key] = routing_key if active_index.routing_enabled? && routing_key
 
-      repository.get(options)
+      repository.get(**options)
     end
 
     def put_item(type: "default", item:, op_type: 'index', routing_key: nil)
       indexes.each do |index|
         options = { entity: item, index: index[:klass], type: type, op_type: op_type }
         options[:routing_key] = routing_key if index[:klass].routing_enabled? && routing_key
 
-        repository.set(options)
+        repository.set(**options)
       end
     end
 
@@ -146,7 +146,7 @@ def delete_item(id:, type: "default", routing_key: nil)
         options = { index: index[:klass], id: id, type: type }
         options[:routing_key] = routing_key if index[:klass].routing_enabled? && routing_key
 
-        repository.drop(options)
+        repository.drop(**options)
       end
     end
 

lib/elastic_search_framework/repository.rb

@@ -74,7 +74,7 @@ def drop(index:, id:, type: 'default', routing_key: nil)
     end
 
     def query(index:, expression:, type: 'default', limit: 10, count: false, routing_key: nil)
-      uri_string = "#{host}/#{index.full_name}/#{type}/_search?q=#{URI.encode(expression)}&size=#{limit}"
+      uri_string = "#{host}/#{index.full_name}/#{type}/_search?q=#{CGI::escape(expression)}&size=#{limit}"
       uri_string += "&routing=#{routing_key}" if routing_key
 
       uri = URI(uri_string)

lib/elastic_search_framework/version.rb

@@ -1,3 +1,3 @@
 module ElasticSearchFramework
-  VERSION = '2.4.0'
+  VERSION = '2.4.1'
 end