qt-creator(-cdb-ext)-git: Add version 19.0.1#2842
Open
e-gleba wants to merge 2 commits into
Open
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughAdded three Scoop package manifests for Qt Creator version 19.0.1: the main Qt Creator application, a CDB debugger extension, and a wininterrupt component. Each manifest specifies download URLs, SHA256 hashes, dependencies, post-install hooks, and automatic update configuration for Windows. ChangesQt Creator Package Ecosystem
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
z-Fng
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/qt-creator-cdb-ext-git.json`:
- Line 20: The Remove-Item invocation that deletes qtcreatorcdbext* can emit a
non-terminating error on first install when the glob matches nothing; update the
command string in bucket/qt-creator-cdb-ext-git.json (the line containing
Remove-Item "$(appdir qt-creator-git $global)\\current\\lib\\qtcreatorcdbext*")
to add the PowerShell flag -ErrorAction SilentlyContinue (keeping -Force
-Recurse) so the command suppresses the spurious error when no items exist.
- Around line 19-22: Add a pre_uninstall step to remove the junctions created by
post_install so they don't become dangling when this package is removed: create
a "pre_uninstall" array that runs the same Remove-Item command used in
post_install (the Remove-Item targeting "$(appdir qt-creator-git
$global)\\current\\lib\\qtcreatorcdbext*" ) so junctions are deleted before the
versioned $dir is removed; ensure the new pre_uninstall entry mirrors the
cleanup logic currently in post_install.
In `@bucket/qt-creator-wininterrupt-git.json`:
- Line 19: The package creates hard links in qt-creator-git via the post_install
command which leaves orphaned executables on uninstall; add a pre_uninstall
entry that finds the same names (the "(Get-Item
$dir\\bin\\win*interrupt.exe).Name" pattern) and removes matching files from
"$(appdir qt-creator-git $global)\\current\\bin\\" (use Remove-Item with
-Force/-ErrorAction to quietly delete each matching hard link), ensuring you
mirror the same name-selection logic used in post_install so the exact linked
filenames are removed before uninstalling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8fb43f26-1ce2-409f-9ff0-b49cd014abdb
📒 Files selected for processing (3)
bucket/qt-creator-cdb-ext-git.jsonbucket/qt-creator-git.jsonbucket/qt-creator-wininterrupt-git.json
e-gleba
force-pushed
the
qt-creator-git
branch
3 times, most recently
from
642b8cb to
5419321
Compare
qt-creator-git: polish manifests for professional quality
- Add `conflicts_with` to prevent side-by-side installation with
official
`extras/qt-creator` and `extras/qt-creator-cdb-ext` packages
- Improve `notes` to explicitly mention x64-only limitation (GitHub
releases
do not provide arm64 builds, unlike official Qt mirrors)
- Replace placeholder fake MD5 hashes with `TODO` markers to signal that
real hashes must be computed before merge
- Keep `checkver`/`autoupdate` structure aligned with Scoop conventions
- No functional URL or dependency changes
qt-creator-git: fix schema violations, remove invalid fields
- Remove `conflicts_with` — this field does not exist in Scoop schema
(schema.json has no such property; conflict warnings moved to `notes`)
- Remove invalid `"hash": "TODO"` — does not match hashPattern regex
(schema requires md5:32hex, sha256:64hex, etc.)
- Omit `hash` entirely for now — schema-valid, install will warn
(real hashes must be computed from release assets before merge)
- Expand `notes` to explicitly warn about side-by-side install conflict
with official `extras/qt-creator` and `extras/qt-creator-cdb-ext`
- All other fields remain unchanged and schema-valid
qt-creator-git: add real SHA256 hashes, add wininterrupt companion
- Add verified SHA256 hashes from GitHub release API digest field:
- qtcreator-windows-x64-msvc-19.0.1.7z:
d6bc6068587297ce2dc38787bc5ace43368f85ea59520117d2a702d59bd6e40f
- qtcreatorcdbext-windows-x64-msvc-19.0.1.7z:
cc042c1e5569c1ee5637dab034d02a8309b13214d6b32bcfc8655459d97f528a
- wininterrupt-windows-x64-msvc-19.0.1.7z:
d4c843d7a3daa1c203ed77c5797fe90251e5b1e8cc2a5a8409840d55e34faba9
- Add qt-creator-wininterrupt-git.json for full parity with Extras
bucket trio
- All manifests schema-valid, conflict warnings in notes, x64-only
documented
- qt-creator-cdb-ext-git.json: add -ErrorAction SilentlyContinue to post_install Remove-Item to suppress spurious error on fresh install when no prior qtcreatorcdbext* items exist - qt-creator-cdb-ext-git.json: add pre_uninstall to remove junctions from qt-creator-git's lib before uninstall, preventing dangling junction references - qt-creator-wininterrupt-git.json: add pre_uninstall to remove hard links from qt-creator-git's bin before uninstall, preventing orphaned executables after package removal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
qt-creator-git,qt-creator-cdb-ext-git, andqt-creator-wininterrupt-gitmanifests to the Versions bucket, as discussed in ScoopInstaller/Extras#17716.These manifests download Qt Creator from the official Qt Creator GitHub releases instead of the Qt official mirrors (
download.qt.io), which are often slow or unreliable for users in certain regions.Key points:
qt-creatormanifest untouched in Extras bucketnotesfield warning that these are not officially supported builds per the GitHub release disclaimerqt-creator-cdb-ext-gitandqt-creator-wininterrupt-gitdepend onversions/qt-creator-gitqt-creator,qt-creator-cdb-ext,qt-creator-wininterrupt)Verified SHA256 hashes (from GitHub release API
digestfield):qtcreator-windows-x64-msvc-19.0.1.7z:d6bc6068587297ce2dc38787bc5ace43368f85ea59520117d2a702d59bd6e40fqtcreatorcdbext-windows-x64-msvc-19.0.1.7z:cc042c1e5569c1ee5637dab034d02a8309b13214d6b32bcfc8655459d97f528awininterrupt-windows-x64-msvc-19.0.1.7z:d4c843d7a3daa1c203ed77c5797fe90251e5b1e8cc2a5a8409840d55e34faba9Closes the discussion in Extras#17716 about providing an alternative download source.
Summary by CodeRabbit