Refactor MockDatabaseTest and LastNFiscalQuartersComparable to use Gmt.startOfThisFiscalQuarter for improved accuracy in date handling and assertions in tests (#313)

Author: ZackFra

moxygen/main/default/classes/database/MockDatabaseTest.cls

@@ -7149,12 +7149,12 @@ private class MockDatabaseTest {
     @isTest
     static void ensureLasNFiscalQuartersWorksInWhereClause() {
         List<Opportunity> oppList = new List<Opportunity>();
-        Date startOfYear = Date.newInstance(Gmt.today().year(), 1, 1);
+        Date startOfThisFiscalQuarter = Gmt.startOfThisFiscalQuarter();
         for (Integer i = 0; i < 36; i++) {
             oppList.add(
                 new Opportunity(
                     Name = 'Opp' + i,
-                    CloseDate = startOfYear.addMonths(-i)
+                    CloseDate = startOfThisFiscalQuarter.addMonths(-i)
                 )
             );
         }
@@ -7168,12 +7168,11 @@ private class MockDatabaseTest {
         Test.stopTest();
 
         Assert.areEqual(
-            3,
+            6,
             opportunities.size(),
             'Incorrect number of opportunities'
         );
 
-        Date startOfThisFiscalQuarter = Gmt.startOfThisFiscalQuarter();
         Date startDate = startOfThisFiscalQuarter.addMonths(-6);
         for (Opportunity opp : opportunities) {
             Assert.isTrue(

moxygen/main/default/classes/database/soql-engine/interpreter/operator-handler/date-literal-comparable/LastNFiscalQuartersComparable.cls

@@ -14,10 +14,8 @@ public with sharing class LastNFiscalQuartersComparable extends DateLiteralCompa
     }
 
     public override Boolean isGreaterThan(Datetime fieldValue) {
-        Integer nMonthsAgo = this.n * 3;
-        // Does NOT include the current quarter, thus the -3
-        Date nFiscalQuartersAgo = Gmt.startOfthisFiscalQuarter()
-            .addMonths(-nMonthsAgo);
-        return fieldValue >= nFiscalQuartersAgo.addMonths(3);
+        // For LAST_N_FISCAL_QUARTERS, isGreaterThan should return true
+        // when fieldValue is >= the start of the current fiscal quarter
+        return fieldValue >= Gmt.startOfthisFiscalQuarter();
     }
 }