Clean up compiler warnings (#451)

Author: sookach

include/CXXGraph/Edge/Edge_decl.h

@@ -59,7 +59,7 @@ class Edge {
   virtual ~Edge() = default;
   void setFirstNode(shared<const Node<T>> node);
   void setSecondNode(shared<const Node<T>> node);
-  const unsigned long long getId() const;
+  unsigned long long getId() const;
   const std::pair<shared<const Node<T>>, shared<const Node<T>>> &getNodePair()
       const;
   shared<const Node<T>> getOtherNode(shared<const Node<T>> node) const;

include/CXXGraph/Edge/Edge_impl.hpp

@@ -79,7 +79,7 @@ void Edge<T>::setSecondNode(shared<const Node<T>> node) {
 }
 
 template <typename T>
-const unsigned long long Edge<T>::getId() const {
+unsigned long long Edge<T>::getId() const {
   return id;
 }
 

include/CXXGraph/Graph/Algorithm/CycleDetection_impl.hpp

@@ -46,7 +46,6 @@ bool Graph<T>::isCyclicDirectedGraphDFS() const {
   for (const auto &node : nodeSet) {
     state[node->getId()] = not_visited;
   }
-  int stateCounter = 0;
 
   // Start visiting each node.
   for (const auto &node : nodeSet) {

include/CXXGraph/Partitioning/EdgeBalancedVertexCut.hpp

@@ -104,7 +104,6 @@ void EdgeBalancedVertexCut<T>::performStep(shared<const Edge<T>> e,
   //*** Check which partition has the less load
   int MIN_LOAD = state->getMachineLoad(0);
   int machine_id = 0;
-  double MAX_SCORE = 0.0;
 
   for (int m = 0; m < P; m++) {
     int load = state->getMachineLoad(m);

include/CXXGraph/Partitioning/Partition.hpp

@@ -274,7 +274,6 @@ unsigned int getMinNodesLoad(const PartitionMap<T> &partitionMap) {
 
 template <typename T>
 unsigned int getNumberOfEdges(const PartitionMap<T> &partitionMap) {
-  unsigned int numberOfEdges = 0;
   T_EdgeSet<T> edgeSet;
 
   for (const auto &it : partitionMap) {
@@ -289,7 +288,6 @@ unsigned int getNumberOfEdges(const PartitionMap<T> &partitionMap) {
 
 template <typename T>
 unsigned int getNumberOfNodes(const PartitionMap<T> &partitionMap) {
-  unsigned int numberOfNodes = 0;
   std::unordered_set<shared<const Node<T>>, nodeHash<T>> nodeSet;
 
   for (const auto &it : partitionMap) {
@@ -358,8 +356,7 @@ std::ostream &operator<<(std::ostream &os, const Partition<T> &partition) {
       os << *std::static_pointer_cast<const UndirectedEdge<T>>(*it) << "\n";
     } else {
       // Should never happens
-      os << "Wrong Edge Class"
-         << "\n";
+      os << "Wrong Edge Class" << "\n";
     }
   }
   return os;

include/CXXGraph/Partitioning/WeightBalancedLibra.hpp

@@ -138,8 +138,6 @@ void WeightBalancedLibra<T>::performStep(shared<const Edge<T>> e,
 
       // according to paper, s refers to node with lower degree, t = {u, v} -
       // {s}
-      size_t s_node = (u_degree > v_degree) ? v : u;
-      size_t t_node = (u_degree > v_degree) ? u : v;
       const std::set<int> &s_partition =
           (u_degree > v_degree) ? v_partition : u_partition;
       const std::set<int> &t_partition =