Fix potential stackoverflow

woyumen4597 · wenshao · commit 8e8ef21f34d3 · 2024-08-15T20:22:12.000+08:00
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/oscar/ast/stmt/OscarAlterSchemaStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/oscar/ast/stmt/OscarAlterSchemaStatement.java
@@ -36,11 +36,7 @@ public void setSchemaName(SQLIdentifierExpr schemaName) {
     }
 
     protected void accept0(SQLASTVisitor visitor) {
-        if (visitor instanceof PGASTVisitor) {
-            accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
-        }
+        accept0((PGASTVisitor) visitor);
     }
 
     public SQLIdentifierExpr getNewName() {
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/oscar/ast/stmt/OscarConnectToStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/oscar/ast/stmt/OscarConnectToStatement.java
@@ -15,11 +15,7 @@ public OscarConnectToStatement() {
     }
 
     protected void accept0(SQLASTVisitor visitor) {
-        if (visitor instanceof PGASTVisitor) {
-            accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
-        }
+        this.accept0((PGASTVisitor) visitor);
     }
 
     @Override
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/oscar/ast/stmt/OscarCreateSchemaStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/oscar/ast/stmt/OscarCreateSchemaStatement.java
@@ -61,11 +61,7 @@ public void setAuthorization(boolean authorization) {
     }
 
     protected void accept0(SQLASTVisitor visitor) {
-        if (visitor instanceof PGASTVisitor) {
-            accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
-        }
+        accept0((PGASTVisitor) visitor);
     }
 
     @Override
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/oscar/ast/stmt/OscarDropSchemaStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/oscar/ast/stmt/OscarDropSchemaStatement.java
@@ -61,11 +61,7 @@ public void setRestrict(boolean restrict) {
     }
 
     protected void accept0(SQLASTVisitor visitor) {
-        if (visitor instanceof PGASTVisitor) {
-            accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
-        }
+        accept0((PGASTVisitor) visitor);
     }
 
     @Override
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/oscar/ast/stmt/OscarFunctionTableSource.java b/core/src/main/java/com/alibaba/druid/sql/dialect/oscar/ast/stmt/OscarFunctionTableSource.java
@@ -44,11 +44,7 @@ public List<SQLParameter> getParameters() {
 
     @Override
     protected void accept0(SQLASTVisitor visitor) {
-        if (visitor instanceof PGASTVisitor) {
-            accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
-        }
+        this.accept0((PGASTVisitor) visitor);
     }
 
     public void accept0(OscarASTVisitor visitor) {
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/oscar/ast/stmt/OscarStartTransactionStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/oscar/ast/stmt/OscarStartTransactionStatement.java
@@ -30,8 +30,6 @@ public OscarStartTransactionStatement() {
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
             accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
         }
     }
 
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/oscar/ast/stmt/OscarUpdateStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/oscar/ast/stmt/OscarUpdateStatement.java
@@ -39,9 +39,10 @@ public void setOnly(boolean only) {
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
             accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
+            return;
         }
+
+        super.accept0(visitor);
     }
 
     @Override
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/PGSQLObjectImpl.java b/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/PGSQLObjectImpl.java
@@ -26,9 +26,7 @@ public PGSQLObjectImpl() {
     @Override
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
-            accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept(visitor);
+            this.accept0((PGASTVisitor) visitor);
         }
     }
 
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/expr/PGExprImpl.java b/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/expr/PGExprImpl.java
@@ -28,8 +28,6 @@ public abstract class PGExprImpl extends SQLExprImpl implements PGExpr {
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
             accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept(visitor);
         }
     }
 
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/expr/PGTypeCastExpr.java b/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/expr/PGTypeCastExpr.java
@@ -43,9 +43,10 @@ public void accept0(PGASTVisitor visitor) {
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
             accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
+            return;
         }
+
+        super.accept0(visitor);
     }
 
     @Override
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGAlterSchemaStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGAlterSchemaStatement.java
@@ -37,8 +37,6 @@ public void setSchemaName(SQLIdentifierExpr schemaName) {
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
             accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
         }
     }
 
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGConnectToStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGConnectToStatement.java
@@ -15,9 +15,7 @@ public PGConnectToStatement() {
 
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
-            accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
+            this.accept0((PGASTVisitor) visitor);
         }
     }
 
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGCreateSchemaStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGCreateSchemaStatement.java
@@ -62,8 +62,6 @@ public void setAuthorization(boolean authorization) {
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
             accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
         }
     }
 
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGDoStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGDoStatement.java
@@ -26,8 +26,6 @@ public class PGDoStatement extends SQLStatementImpl implements PGSQLStatement {
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
             accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
         }
     }
 
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGDropSchemaStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGDropSchemaStatement.java
@@ -62,8 +62,6 @@ public void setRestrict(boolean restrict) {
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
             accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
         }
     }
 
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGEndTransactionStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGEndTransactionStatement.java
@@ -22,7 +22,7 @@
 
 /**
  * @author lizongbo
- * @see <a href="https://www.postgresql.org/docs/current/sql-end.html">end语法</a>
+ * @see  <a href="https://www.postgresql.org/docs/current/sql-end.html">end语法</a>
  */
 public class PGEndTransactionStatement extends SQLStatementImpl implements PGSQLStatement {
     public PGEndTransactionStatement() {
@@ -33,8 +33,6 @@ public PGEndTransactionStatement() {
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
             accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
         }
     }
 
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGFunctionTableSource.java b/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGFunctionTableSource.java
@@ -44,8 +44,6 @@ public List<SQLParameter> getParameters() {
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
             this.accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
         }
     }
 
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGShowStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGShowStatement.java
@@ -44,8 +44,6 @@ public void setExpr(SQLExpr expr) {
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
             accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
         }
     }
 
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGStartTransactionStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGStartTransactionStatement.java
@@ -39,8 +39,6 @@ public void setUseBegin(boolean useBegin) {
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
             accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
         }
     }
 
diff --git a/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGUpdateStatement.java b/core/src/main/java/com/alibaba/druid/sql/dialect/postgresql/ast/stmt/PGUpdateStatement.java
@@ -38,9 +38,10 @@ public void setOnly(boolean only) {
     protected void accept0(SQLASTVisitor visitor) {
         if (visitor instanceof PGASTVisitor) {
             accept0((PGASTVisitor) visitor);
-        } else {
-            super.accept0(visitor);
+            return;
         }
+
+        super.accept0(visitor);
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -36,11 +36,7 @@ public void setSchemaName(SQLIdentifierExpr schemaName) {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`protected void accept0(SQLASTVisitor visitor) {`
`39`		`- if (visitor instanceof PGASTVisitor) {`
`40`		`- accept0((PGASTVisitor) visitor);`
`41`		`- } else {`
`42`		`- super.accept0(visitor);`
`43`		`- }`
	`39`	`+ accept0((PGASTVisitor) visitor);`
`44`	`40`	`}`
`45`	`41`
`46`	`42`	`public SQLIdentifierExpr getNewName() {`
Original file line number	Diff line number	Diff line change
`@@ -15,11 +15,7 @@ public OscarConnectToStatement() {`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`protected void accept0(SQLASTVisitor visitor) {`
`18`		`- if (visitor instanceof PGASTVisitor) {`
`19`		`- accept0((PGASTVisitor) visitor);`
`20`		`- } else {`
`21`		`- super.accept0(visitor);`
`22`		`- }`
	`18`	`+ this.accept0((PGASTVisitor) visitor);`
`23`	`19`	`}`
`24`	`20`
`25`	`21`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -61,11 +61,7 @@ public void setAuthorization(boolean authorization) {`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`protected void accept0(SQLASTVisitor visitor) {`
`64`		`- if (visitor instanceof PGASTVisitor) {`
`65`		`- accept0((PGASTVisitor) visitor);`
`66`		`- } else {`
`67`		`- super.accept0(visitor);`
`68`		`- }`
	`64`	`+ accept0((PGASTVisitor) visitor);`
`69`	`65`	`}`
`70`	`66`
`71`	`67`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -61,11 +61,7 @@ public void setRestrict(boolean restrict) {`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`protected void accept0(SQLASTVisitor visitor) {`
`64`		`- if (visitor instanceof PGASTVisitor) {`
`65`		`- accept0((PGASTVisitor) visitor);`
`66`		`- } else {`
`67`		`- super.accept0(visitor);`
`68`		`- }`
	`64`	`+ accept0((PGASTVisitor) visitor);`
`69`	`65`	`}`
`70`	`66`
`71`	`67`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,6 @@ public OscarStartTransactionStatement() {`
`30`	`30`	`protected void accept0(SQLASTVisitor visitor) {`
`31`	`31`	`if (visitor instanceof PGASTVisitor) {`
`32`	`32`	`accept0((PGASTVisitor) visitor);`
`33`		`- } else {`
`34`		`- super.accept0(visitor);`
`35`	`33`	`}`
`36`	`34`	`}`
`37`	`35`
Original file line number	Diff line number	Diff line change
`@@ -39,9 +39,10 @@ public void setOnly(boolean only) {`
`39`	`39`	`protected void accept0(SQLASTVisitor visitor) {`
`40`	`40`	`if (visitor instanceof PGASTVisitor) {`
`41`	`41`	`accept0((PGASTVisitor) visitor);`
`42`		`- } else {`
`43`		`- super.accept0(visitor);`
	`42`	`+ return;`
`44`	`43`	`}`
	`44`	`+`
	`45`	`+ super.accept0(visitor);`
`45`	`46`	`}`
`46`	`47`
`47`	`48`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -26,9 +26,7 @@ public PGSQLObjectImpl() {`
`26`	`26`	`@Override`
`27`	`27`	`protected void accept0(SQLASTVisitor visitor) {`
`28`	`28`	`if (visitor instanceof PGASTVisitor) {`
`29`		`- accept0((PGASTVisitor) visitor);`
`30`		`- } else {`
`31`		`- super.accept(visitor);`
	`29`	`+ this.accept0((PGASTVisitor) visitor);`
`32`	`30`	`}`
`33`	`31`	`}`
`34`	`32`
Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,6 @@ public abstract class PGExprImpl extends SQLExprImpl implements PGExpr {`
`28`	`28`	`protected void accept0(SQLASTVisitor visitor) {`
`29`	`29`	`if (visitor instanceof PGASTVisitor) {`
`30`	`30`	`accept0((PGASTVisitor) visitor);`
`31`		`- } else {`
`32`		`- super.accept(visitor);`
`33`	`31`	`}`
`34`	`32`	`}`
`35`	`33`
Original file line number	Diff line number	Diff line change
`@@ -43,9 +43,10 @@ public void accept0(PGASTVisitor visitor) {`
`43`	`43`	`protected void accept0(SQLASTVisitor visitor) {`
`44`	`44`	`if (visitor instanceof PGASTVisitor) {`
`45`	`45`	`accept0((PGASTVisitor) visitor);`
`46`		`- } else {`
`47`		`- super.accept0(visitor);`
	`46`	`+ return;`
`48`	`47`	`}`
	`48`	`+`
	`49`	`+ super.accept0(visitor);`
`49`	`50`	`}`
`50`	`51`
`51`	`52`	`@Override`