IGNITE-26740 Refactor GridIntList: remove extra methods

Author: chesnokoff

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxImplicitSingleStateImpl.java

@@ -73,7 +73,7 @@ public class IgniteTxImplicitSingleStateImpl extends IgniteTxLocalStateAdapter {
 
     /** {@inheritDoc} */
     @Nullable @Override public GridIntList cacheIds() {
-        return GridIntList.asList(cacheCtx.cacheId());
+        return new GridIntList(new int[]{cacheCtx.cacheId()});
     }
 
     /** {@inheritDoc} */

modules/core/src/main/java/org/apache/ignite/internal/processors/performancestatistics/FilePerformanceStatisticsWriter.java

@@ -37,7 +37,6 @@
 import org.apache.ignite.internal.processors.cache.persistence.file.RandomAccessFileIOFactory;
 import org.apache.ignite.internal.processors.cache.persistence.wal.SegmentedRingByteBuffer;
 import org.apache.ignite.internal.processors.cache.query.GridCacheQueryType;
-import org.apache.ignite.internal.util.GridIntIterator;
 import org.apache.ignite.internal.util.GridIntList;
 import org.apache.ignite.internal.util.typedef.internal.U;
 import org.apache.ignite.internal.util.worker.GridWorker;
@@ -233,10 +232,8 @@ public void transaction(GridIntList cacheIds, long startTime, long duration, boo
         doWrite(commited ? TX_COMMIT : TX_ROLLBACK, transactionRecordSize(cacheIds.size()), buf -> {
             buf.putInt(cacheIds.size());
 
-            GridIntIterator iter = cacheIds.iterator();
-
-            while (iter.hasNext())
-                buf.putInt(iter.next());
+            for (int i = 0; i < cacheIds.size(); i++)
+                buf.putInt(cacheIds.get(i));
 
             buf.putLong(startTime);
             buf.putLong(duration);

modules/core/src/main/java/org/apache/ignite/internal/util/GridIntList.java

@@ -22,7 +22,6 @@
 import java.io.ObjectInput;
 import java.io.ObjectOutput;
 import java.util.Arrays;
-import org.apache.ignite.internal.util.typedef.F;
 import org.apache.ignite.internal.util.typedef.internal.S;
 import org.apache.ignite.internal.util.typedef.internal.SB;
 
@@ -66,54 +65,13 @@ public GridIntList(int[] arr) {
         idx = arr.length;
     }
 
-    /**
-     * @param vals Values.
-     * @return List from values.
-     */
-    public static GridIntList asList(int... vals) {
-        if (F.isEmpty(vals))
-            return new GridIntList();
-
-        return new GridIntList(vals);
-    }
-
-    /**
-     * @param arr Array.
-     * @param size Size.
-     */
-    private GridIntList(int[] arr, int size) {
-        this.arr = arr;
-        idx = size;
-    }
-
     /**
      * @return Array.
      */
     public int[] array() {
         return arr;
     }
 
-    /**
-     * @param arr New array.
-     */
-    public void array(int[] arr) {
-        this.arr = arr;
-    }
-
-    /**
-     * @return Index.
-     */
-    public int idx() {
-        return idx;
-    }
-
-    /**
-     * @param idx New index.
-     */
-    public void idx(int idx) {
-        this.idx = idx;
-    }
-
     /** {@inheritDoc} */
     @Override public boolean equals(Object o) {
         if (this == o)
@@ -319,21 +277,4 @@ public GridIntList sort() {
 
         return this;
     }
-
-    /**
-     * @return Iterator.
-     */
-    public GridIntIterator iterator() {
-        return new GridIntIterator() {
-            int c;
-
-            @Override public boolean hasNext() {
-                return c < idx;
-            }
-
-            @Override public int next() {
-                return arr[c++];
-            }
-        };
-    }
 }

modules/core/src/test/java/org/apache/ignite/util/GridIntListSelfTest.java

@@ -20,7 +20,6 @@
 import org.apache.ignite.internal.util.GridIntList;
 import org.junit.Test;
 
-import static org.apache.ignite.internal.util.GridIntList.asList;
 import static org.junit.Assert.assertEquals;
 
 /**
@@ -97,4 +96,9 @@ public void testSort() {
         assertEquals(asList(1, 3, 4, 5, 0), list);
         assertEquals(asList(0, 1, 3, 4, 5), list.sort());
     }
+
+    /** */
+    private static GridIntList asList(int... vals) {
+        return new GridIntList(vals);
+    }
 }