Skip to content

Commit baee1ab

Browse files
nicob3ysadpandajoe
authored andcommitted
fix(Table Chart): render null dates properly (#34558)
(cherry picked from commit 65376c7)
1 parent a8cf098 commit baee1ab

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ import { formatColumnValue } from './utils/formatValue';
8989
import { PAGE_SIZE_OPTIONS, SERVER_PAGE_SIZE_OPTIONS } from './consts';
9090
import { updateTableOwnState } from './DataTable/utils/externalAPIs';
9191
import getScrollBarSize from './DataTable/utils/getScrollBarSize';
92+
import DateWithFormatter from './utils/DateWithFormatter';
9293

9394
type ValueRange = [number, number];
9495

@@ -936,7 +937,10 @@ export default function TableChart<D extends DataRecord = DataRecord>(
936937
},
937938
className: [
938939
className,
939-
value == null ? 'dt-is-null' : '',
940+
value == null ||
941+
(value instanceof DateWithFormatter && value.input == null)
942+
? 'dt-is-null'
943+
: '',
940944
isActiveFilterValue(key, value) ? ' dt-is-active-filter' : '',
941945
].join(' '),
942946
tabIndex: 0,

0 commit comments

Comments
 (0)