Move the custom database errors to a separate config file

Author: DamianPendrak

docs/docs/configuration/databases.mdx

@@ -1770,7 +1770,7 @@ You can use the `Extra` field in the **Edit Databases** form to configure SSL:
 }
 ```
 ##### Custom Error Messages
-You can use the ``CUSTOM_DATABASE_ERRORS`` setting in your ``superset_config.py`` to configure custom error messages for database exceptions.
+You can use the `CUSTOM_DATABASE_ERRORS` in the `superset/custom_database_errors.py` file or overwrite it in your config file to configure custom error messages for database exceptions.
 
 This feature lets you transform raw database errors into user-friendly messages, optionally including documentation links and hiding default error codes.
 
@@ -1794,7 +1794,7 @@ CUSTOM_DATABASE_ERRORS = {
             }
         )
     },
-    "postgres": {}
+    "PostgreSQL": {}
 }
 ```
 

superset/config.py

@@ -52,7 +52,6 @@
 from superset.advanced_data_type.plugins.internet_port import internet_port
 from superset.advanced_data_type.types import AdvancedDataType
 from superset.constants import CHANGE_ME_SECRET_KEY
-from superset.errors import SupersetErrorType
 from superset.jinja_context import BaseTemplateProcessor
 from superset.key_value.types import JsonKeyValueCodec
 from superset.stats_logger import DummyStatsLogger
@@ -2153,33 +2152,13 @@ class ExtraDynamicQueryFilters(TypedDict, total=False):
 # keeping a web API call open for this long.
 SYNC_DB_PERMISSIONS_IN_ASYNC_MODE: bool = False
 
-# CUSTOM_DATABASE_ERRORS: Configure custom error messages for database exceptions.
+# CUSTOM_DATABASE_ERRORS: Configure custom error messages for database exceptions
+# in superset/custom_database_errors.py.
 # Transform raw database errors into user-friendly messages with optional documentation
-# links using custom_doc_links. Set show_issue_info=False to hide default error codes.
-# Example:
-# CUSTOM_DATABASE_ERRORS = {
-#     "trino": {
-#         re.compile(r'message="(?P<message>[^"]*)"'): (
-#             __(
-#                 'Unexpected error: "%(message)s"'
-#             ),
-#             SupersetErrorType.GENERIC_DB_ENGINE_ERROR,
-#             {
-#                 "custom_doc_links": [
-#                     {
-#                         "url": "https://example.com/docs/1",
-#                         "label": "Check documentation"
-#                     },
-#                 ],
-#                 "show_issue_info": False,
-#             }
-#         )
-#     }
-# }
-
-CUSTOM_DATABASE_ERRORS: dict[
-    str, dict[re.Pattern[str], tuple[str, SupersetErrorType, dict[str, Any]]]
-] = {}
+try:
+    from superset.custom_database_errors import CUSTOM_DATABASE_ERRORS
+except ImportError:
+    CUSTOM_DATABASE_ERRORS = {}
 
 
 # -------------------------------------------------------------------

superset/custom_database_errors.py

@@ -0,0 +1,49 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import re
+from typing import Any
+
+from superset.errors import SupersetErrorType
+
+# CUSTOM_DATABASE_ERRORS: Configure custom error messages for database exceptions.
+# Transform raw database errors into user-friendly messages with optional documentation
+# links using custom_doc_links. Set show_issue_info=False to hide default error codes.
+# Example:
+# CUSTOM_DATABASE_ERRORS = {
+#     "trino": {
+#         re.compile(r'message="(?P<message>[^"]*)"'): (
+#             __(
+#                 'Unexpected error: "%(message)s"'
+#             ),
+#             SupersetErrorType.GENERIC_DB_ENGINE_ERROR,
+#             {
+#                 "custom_doc_links": [
+#                     {
+#                         "url": "https://example.com/docs/1",
+#                         "label": "Check documentation"
+#                     },
+#                 ],
+#                 "show_issue_info": False,
+#             }
+#         )
+#     }
+# }
+
+CUSTOM_DATABASE_ERRORS: dict[
+    str, dict[re.Pattern[str], tuple[str, SupersetErrorType, dict[str, Any]]]
+] = {}