unit test for JSON parse failure

Author: ssbrewster

package.json

@@ -11,6 +11,7 @@
     "lodash": "~1.0.0-rc.3",
     "mocha": "*",
     "nconf": "^0.10.0",
+    "nock": "^10.0.1",
     "should": "~1.2.1"
   },
   "keywords": [

test/auth.tests.js

@@ -1,37 +1,38 @@
 var assert = require('assert')
-    , auth = require("../lib/auth")
-    , config = require('./config');
+  , auth = require("../lib/auth")
+  , config = require('./config');
 
 describe('login to waad', function () {
-    it('should obtain an access token', function (done) {
-        auth.getAccessToken(config.v1.TENANTID, config.v1.APPPRINCIPALID, config.v1.SYMMETRICKEY, function(err, token) {
-            if (err) {
-                console.log(err);
-            }
+  it('should obtain an access token', function (done) {
+    auth.getAccessToken(config.v1.TENANTID, config.v1.APPPRINCIPALID, config.v1.SYMMETRICKEY, function(err, token) {
+      if (err) {
+        console.log(err);
+        return done(err);
+      }
 
-            assert.notEqual(null, token);
-            done();
-        });
+      assert.notEqual(null, token);
+      done();
     });
+  });
 
-    it('should fail for wrong tenantId', function (done) {
-        auth.getAccessToken('wrong-tenant-id', config.v1.APPPRINCIPALID, config.v1.SYMMETRICKEY, function(err, token) {
-            assert.ok(err.message.indexOf('AADSTS90002: No service namespace named \'wrong-tenant-id\' was found in the data store.'));
-            done();
-        });
+  it('should fail for wrong tenantId', function (done) {
+    auth.getAccessToken('wrong-tenant-id', config.v1.APPPRINCIPALID, config.v1.SYMMETRICKEY, function(err, token) {
+      assert.ok(err.message.indexOf('AADSTS90002: No service namespace named \'wrong-tenant-id\' was found in the data store.'));
+      done();
     });
+  });
 
-    it('should fail for wrong service principal', function (done) {
-        auth.getAccessToken(config.v1.TENANTID, 'wrong-principal', config.v1.SYMMETRICKEY, function(err, token) {
-            assert.ok(err.message.indexOf('AADSTS70001: Application with identifier \'wrong-principal\' was not found in the directory') > -1);
-            done();
-        });
+  it('should fail for wrong service principal', function (done) {
+    auth.getAccessToken(config.v1.TENANTID, 'wrong-principal', config.v1.SYMMETRICKEY, function(err, token) {
+      assert.ok(err.message.indexOf('AADSTS70001: Application with identifier \'wrong-principal\' was not found in the directory') > -1);
+      done();
     });
+  });
 
-    it('should fail for wrong service key', function (done) {
-        auth.getAccessToken(config.v1.TENANTID, config.v1.APPPRINCIPALID, 'wrong-key', function(err, token) {
-            assert.ok(err.message.indexOf('AADSTS70002: Error validating credentials. AADSTS50012: Client assertion contains an invalid signature.') > -1);
-            done();
-        });
+  it('should fail for wrong service key', function (done) {
+    auth.getAccessToken(config.v1.TENANTID, config.v1.APPPRINCIPALID, 'wrong-key', function(err, token) {
+      assert.ok(err.message.indexOf('AADSTS70002: Error validating credentials. AADSTS50012: Client assertion contains an invalid signature.') > -1);
+      done();
     });
+  });
 });

test/auth2.tests.js

@@ -0,0 +1,72 @@
+var assert = require('assert')
+  , auth = require('../lib/auth')
+  , config = require('./config')
+  , nock = require('nock');
+
+describe('login to waad', function () {
+  function assertParseError(actual, expected, token) {
+    assert.deepEqual(actual, expected);
+    assert.equal(token, null);
+  }
+
+  var message = 'Failed to parse response from graph API';
+  var parseError = new Error(message);
+
+  parseError.name = 'waad_parse_error';
+  parseError.stack = 'Error stack'
+  parseError.body = { error: 'body' };
+
+  var tenantId = config.v1.TENANTID;
+  var spnAppPrincipalId = config.v1.APPPRINCIPALID;
+  var spnSymmetricKeyBase64 = config.v1.SYMMETRICKEY;
+  var tenantDomain = config.v2.WAAD_TENANTDOMAIN;
+  var clientId = config.v2.WAAD_CLIENTID;
+  var clientSecret = config.v2.WAAD_CLIENTSECRET;
+
+  describe('v1 fails to parse JSON response', function () {
+    afterEach(function () {
+      nock.cleanAll();
+    });
+
+    it('should return error details when it fails to parse the JSON response when getting an access token', function (done) {
+      nock('https://accounts.accesscontrol.windows.net')
+        .post('/tokens/OAuth/2')
+        .replyWithError(parseError);
+
+      auth.getAccessToken(tenantId, spnAppPrincipalId, spnSymmetricKeyBase64, function(err, token) {
+        assertParseError(err, parseError, token);
+        done();
+      });
+    });
+
+    it('should return error details when it fails to parse the JSON response when getting an access token with client credentials', function (done) {
+      nock('https://accounts.accesscontrol.windows.net')
+        .post('/' + tenantId + '/tokens/OAuth/2')
+        .replyWithError(parseError);
+
+      auth.getAccessTokenWithClientCredentials(tenantId, spnAppPrincipalId, clientId, clientSecret, function(err, token) {
+        assertParseError(err, parseError, token);
+        done();
+      });
+    });
+  });
+
+  describe('v2 fails to parse JSON response', function () {
+    beforeEach(function () {
+      nock('https://login.windows.net')
+        .post('/' + tenantDomain + '/oauth2/token')
+        .replyWithError(parseError);
+    });
+
+    afterEach(function () {
+      nock.cleanAll();
+    });
+
+    it('should return error details when it fails to parse the JSON response', function (done) {
+      auth.getAccessTokenWithClientCredentials2(tenantDomain, clientId, clientSecret, function(err, token) {
+        assertParseError(err, parseError, token);
+        done();
+      });
+    });
+  });
+});