hl-todo theming

[anarcat]

Hi!

The default hl-todo does not seem to be compatible with solarized-theme:

(defcustom hl-todo-keyword-faces
  '(("HOLD" . "#d0bf8f")
    ("TODO" . "#cc9393")
    ("NEXT" . "#dca3a3")
    ("THEM" . "#dc8cc3")
    ("PROG" . "#7cb8bb")
    ("OKAY" . "#7cb8bb")
    ("DONT" . "#5f7f5f")
    ("FAIL" . "#8c5353")
    ("DONE" . "#afd8af")
    ("NOTE"   . "#d0bf8f")
    ("KLUDGE" . "#d0bf8f")
    ("HACK"   . "#d0bf8f")
    ("TEMP"   . "#d0bf8f")
    ("FIXME"  . "#cc9393")
    ("XXX"    . "#cc9393")
    ("XXXX"   . "#cc9393")
    ("???"    . "#cc9393"))
  "Faces used to highlight specific TODO keywords."
  :package-version '(hl-todo . "2.0.0")
  :group 'hl-todo
  :type '(repeat (cons (string :tag "Keyword")
                       (choice :tag "Face   "
                               (string :tag "Color")
                               (sexp :tag "Face")))))

I started tweaking it to match solarized with:

  (setq hl-todo-keyword-faces
        ;; override sepia-like defaults from hl-todo with solarized colors
        ;;
        ;; HACK: i tried to do use solarized color *names* instead of
        ;; hex values here and failed. none of this worked:
        ;;  1. (apply 'solarized-color-rgb-to-hex (solarized-color-name-to-rgb "orange"))
        ;;  2. use ,yellow
        ;;  3. just the color name (bypasses theme)
        ;;
        ;; problem is those colors are defined inside
        ;; `create-solarized-theme' and not available outside of it
        '(("TODO" . "#b58900")  ; yellow
          ("FIXME" . "#dc322f") ; red
          ("XXX" . "#cb4b16")   ; orange
          ("XXXX" . "#8B2C02")  ; orange-d
          ("???" . "#d33682")   ; magenta
          ;; the rest is the original theme
          ("HOLD" . "#d0bf8f")
          ("NEXT" . "#dca3a3")
          ("THEM" . "#dc8cc3")
          ("PROG" . "#7cb8bb")
          ("OKAY" . "#7cb8bb")
          ("DONT" . "#5f7f5f")
          ("FAIL" . "#8c5353")
          ("DONE" . "#afd8af")
          ("NOTE" . "#d0bf8f")
          ("KLUDGE" . "#d0bf8f")
          ("HACK" . "#d0bf8f")
          ("TEMP" . "#d0bf8f"))))

but i'm wondering if it's something to add in the theme or somewhere else. thanks!