Phone Number matches incorrectly

[SkeletalDemise]

I've had numerous false positives with the phone number regex that are obviously wrong. All of these match:

0000000000000
0123456789
3333333333333
3333333333
4444444444444
22223333333
-1606586780

The last one is potentially valid but -1 is not valid in a phone number. +1 is. If it can't be less broad then make the rarity 0.

[RackReaver]

Might need to split this into multiple regex as there are a lot of different standards

• 11 digit (x-xxx-xxx-xxxx)
• 10 digit (xxx-xxx-xxxx)
• 7 digit (xxx-xxxx)

Might need to split this into multiple regex as there are a lot of different standards

• 11 digit (x-xxx-xxx-xxxx)

• 10 digit (xxx-xxx-xxxx)

• 7 digit (xxx-xxxx)

We have an issue for this. #227

[behrad-ahmadpour]

@RackReaver
We can add a Country code field that tests the input number without country code. also, a number can be identified by + at the first of it

[Ajay1812]

@SkeletalDemise Can we use the Python module phonenumbers by running the following command: pip install phonenumbers? Here's some sample code you can review.

import phonenumbers
def is_valid_phone_number(phone_number):
    try:
        # Parse the phone number
        parsed_number = phonenumbers.parse(phone_number, None)
        
        # Check if the number is valid
        is_valid = phonenumbers.is_valid_number(parsed_number)
        
        return is_valid
    except phonenumbers.phonenumberutil.NumberFormatException:
        # Handle invalid phone number format
        return False

# Example usage
phone_number = "+1 650-555-1234"  # Replace with the phone number you want to validate
if is_valid_phone_number(phone_number):
    print(f"The phone number {phone_number} is valid.")
else:
    print(f"The phone number {phone_number} is not valid.")

[OpM3TA]

I just installed and have very little experience with this tool, but I ran it against some tests, and (barring its actually not a valid use case for this software, or an unreasonable expectation) notice it doesn't catch MAC addresses for example, at least when in the format of "DEAD00B33F", I suppose without context it may not be able to differentiate between a MAC and anything else, although it would be better than hitting on what it thinks is a lot of API keys and secrets that are false positives.

Same goes for ntlm hashes