Merge pull request #2891 from chaoss/docker-dev-fix

Docker dev fix: Fixes to commit comments and events

Author: sgoggins

augur/api/routes/pull_request_reports.py

@@ -21,6 +21,12 @@
 from bokeh.models.glyphs import Rect
 from bokeh.transform import dodge, factor_cmap, transform
 
+# from selenium.webdriver import Firefox, FirefoxOptions
+# options = FirefoxOptions()
+# options.headless = True
+# webdriver = Firefox(options=options)
+#export_png(item, path, webdriver=webdriver)
+
 warnings.filterwarnings('ignore')
 
 from augur.api.routes import AUGUR_API_VERSION
@@ -604,6 +610,7 @@ def average_commits_per_PR():
         # opts = FirefoxOptions()
     # opts.add_argument("--headless")
     # driver = webdriver.Firefox(firefox_options=opts)
+    # filename = export_png(grid, timeout=180, webdriver=webdriver)
     filename = export_png(grid, timeout=180)
 
     return send_file(filename)

augur/application/cli/backend.py

@@ -185,7 +185,7 @@ def determine_worker_processes(ratio,maximum):
         sleep_time += 6
 
         #60% of estimate, Maximum value of 45 : Reduced because it can be lower
-        core_num_processes = determine_worker_processes(.40, 50)
+        core_num_processes = determine_worker_processes(.40, 90)
         logger.info(f"Starting core worker processes with concurrency={core_num_processes}")
         core_worker = f"celery -A augur.tasks.init.celery_app.celery_app worker -l info --concurrency={core_num_processes} -n core:{uuid.uuid4().hex}@%h"
         process_list.append(subprocess.Popen(core_worker.split(" ")))

augur/application/cli/collection.py

@@ -125,7 +125,7 @@ def determine_worker_processes(ratio,maximum):
     sleep_time += 6
 
     #60% of estimate, Maximum value of 45: Reduced because not needed
-    core_num_processes = determine_worker_processes(.40, 50)
+    core_num_processes = determine_worker_processes(.40, 90)
     logger.info(f"Starting core worker processes with concurrency={core_num_processes}")
     core_worker = f"celery -A augur.tasks.init.celery_app.celery_app worker -l info --concurrency={core_num_processes} -n core:{uuid.uuid4().hex}@%h"
     process_list.append(subprocess.Popen(core_worker.split(" ")))

augur/application/cli/tasks.py

@@ -36,8 +36,8 @@ def start():
     secondary_worker_process = None
 
     scheduling_worker = f"celery -A augur.tasks.init.celery_app.celery_app worker -l info --concurrency=1 -n scheduling:{uuid.uuid4().hex}@%h -Q scheduling"
-    core_worker = f"celery -A augur.tasks.init.celery_app.celery_app worker -l info --concurrency=50 -n core:{uuid.uuid4().hex}@%h"
-    secondary_worker = f"celery -A augur.tasks.init.celery_app.celery_app worker -l info --concurrency=50 -n secondary:{uuid.uuid4().hex}@%h -Q secondary"
+    core_worker = f"celery -A augur.tasks.init.celery_app.celery_app worker -l info --concurrency=90 -n core:{uuid.uuid4().hex}@%h"
+    secondary_worker = f"celery -A augur.tasks.init.celery_app.celery_app worker -l info --concurrency=20 -n secondary:{uuid.uuid4().hex}@%h -Q secondary"
 
     scheduling_worker_process = subprocess.Popen(scheduling_worker.split(" "))
     core_worker_process = subprocess.Popen(core_worker.split(" "))

augur/tasks/data_analysis/contributor_breadth_worker/contributor_breadth_worker.py

@@ -4,7 +4,7 @@
 from datetime import datetime
 
 from augur.tasks.init.celery_app import celery_app as celery
-from augur.tasks.github.util.github_data_access import GithubDataAccess
+from augur.tasks.github.util.github_data_access import GithubDataAccess, UrlNotFoundException
 from augur.application.db.models import ContributorRepo
 from augur.application.db.lib import bulk_insert_dicts
 from augur.tasks.github.util.github_random_key_auth import GithubRandomKeyAuth
@@ -100,17 +100,22 @@ def contributor_breadth_model(self) -> None:
 
 
         cntrb_events = []
-        for event in github_data_access.paginate_resource(repo_cntrb_url):
+        try:
+            for event in github_data_access.paginate_resource(repo_cntrb_url):
 
-            cntrb_events.append(event)
+                cntrb_events.append(event)
 
-            event_age = datetime.strptime(event["created_at"], "%Y-%m-%dT%H:%M:%SZ")
-            if event_age < newest_event_in_db:
-                logger.info("Found cntrb events we already have...skipping the rest")
-                break
+                event_age = datetime.strptime(event["created_at"], "%Y-%m-%dT%H:%M:%SZ")
+                if event_age < newest_event_in_db:
+                    logger.info("Found cntrb events we already have...skipping the rest")
+                    break
 
-        if len(cntrb_events) == 0:
-            logger.info("There are no cntrb events, or new events for this user.\n")
+            if len(cntrb_events) == 0:
+                logger.info("There are no cntrb events, or new events for this user.\n")
+                continue
+
+        except UrlNotFoundException as e:
+            logger.warning(e)
             continue
 
         events = process_contributor_events(cntrb, cntrb_events, logger, tool_source, tool_version, data_source)

augur/tasks/git/dependency_libyear_tasks/libyear_util/npm_libyear_utils.py

@@ -1,6 +1,6 @@
 import requests
-import logging 
-import traceback 
+import logging
+import traceback
 
 logger = logging.getLogger(__name__)
 
@@ -9,87 +9,81 @@ def get_NPM_data(package):
     r = requests.get(url)
     if r.status_code < 400:
         return r.json()
+    logger.warning(f"Failed to fetch data for package {package}. HTTP Status: {r.status_code}")
     return {}
 
-
 def clean_version(version):
     version = [v for v in version if v.isdigit() or v == '.']
     return ''.join(version)
 
 def split_version(version):
-    #Split version string into list seperated by .
-    #assign elements of list to respective variables.
     version_list = list(version.split('.'))
     patch = version_list.pop(-1)
     minor = version_list.pop(-1)
     major = version_list[0]
-
-    return major,minor,patch
-
-
+    return major, minor, patch
 
 def get_latest_patch(version, data):
+    if 'versions' not in data:
+        logger.error(f"'versions' key not found in the NPM data for version {version}. Data: {data}")
+        raise KeyError("'versions' key not found")
+    
     versions = data['versions']
     try:
         index = list(versions.keys()).index(version)
     except ValueError as e:
+        logger.error(f"Version {version} not found in the 'versions' list. Error: {e}")
         raise e
 
-    major,minor,patch = split_version(version)
+    major, minor, patch = split_version(version)
     consider_version = version
     for v in list(versions.keys())[index:]:
-        if v.split('.')[0]==major:
-            if v.split('.')[1]== minor:
-                if v.split('.')[2]>patch:
+        if v.split('.')[0] == major:
+            if v.split('.')[1] == minor:
+                if v.split('.')[2] > patch:
                     consider_version = v
     return consider_version
 
-
 def get_lastest_minor(version, data):
-    try: 
-        versions = data['versions']
-    except Exception as e: 
-        logger.info(
-                    ''.join(traceback.format_exception(None, e, e.__traceback__)))
-      #  raise e 
-        
+    if 'versions' not in data:
+        logger.error(f"'versions' key not found in the NPM data. Data: {data}")
+        raise KeyError("'versions' key not found")
+    
+    versions = data['versions']
     try:
         index = list(versions.keys()).index(version)
     except ValueError as e:
-        logger.info(f'error is {e} on the NPM. Some kind of value error. Probably a VALUES error for Node, #AmIRight?')
+        logger.info(f"Version {version} not found in the 'versions' list. Error: {e}")
         raise e
 
-    major,minor,patch = split_version(version)
-    
+    major, minor, patch = split_version(version)
     consider_version = get_latest_patch(version, data)
     for v in list(versions.keys())[index:]:
-        if v.split('.')[0]==major:
-            if v.split('.')[1]>minor:
-                    consider_version = v
-    return consider_version 
-
+        if v.split('.')[0] == major:
+            if v.split('.')[1] > minor:
+                consider_version = v
+    return consider_version
 
 def get_npm_release_date(data, version):
-    release_time = data['time'][version]
+    release_time = data['time'].get(version)
     if release_time:
         return release_time
+    logger.warning(f"Release time not found for version {version}")
     return None
 
-
 def get_npm_latest_version(data):
-    return data['dist-tags']['latest']
+    return data['dist-tags'].get('latest', 'unknown')
 
-#add code here
 def get_npm_current_version(data, requirement):
-    if requirement[0]=='~':
+    if requirement[0] == '~':
         try:
             return get_latest_patch(clean_version(requirement), data)
         except ValueError:
             return None
-    elif requirement[0]=='^':
+    elif requirement[0] == '^':
         try:
             return get_lastest_minor(clean_version(requirement), data)
         except ValueError:
             return None
     else:
-        return requirement
+        return requirement

augur/tasks/git/dependency_tasks/tasks.py

@@ -3,6 +3,7 @@
 from augur.tasks.git.dependency_tasks.core import *
 from augur.tasks.init.celery_app import celery_app as celery
 from augur.tasks.init.celery_app import AugurFacadeRepoCollectionTask, AugurSecondaryRepoCollectionTask
+from augur.tasks.util.metadata_exception import MetadataException 
 
 
 @celery.task(base=AugurFacadeRepoCollectionTask)
@@ -20,4 +21,26 @@ def process_ossf_dependency_metrics(self, repo_git):
 
     logger = logging.getLogger(process_ossf_dependency_metrics.__name__)
 
-    generate_scorecard(logger, repo_git)
+    try:
+        generate_scorecard(logger, repo_git)
+    except Exception as e:
+        logger.warning(f'Exception generating scorecard: {e}')
+        tracer = ''.join(traceback.format_exception(type(e), e, e.__traceback__))
+        logger.warning(f'Full stack trace of OpenSSF scorecard error: {tracer}')
+        raise MetadataException(f"An error occurred while generating the scorecard: {str(e)}")
+    
+    """
+        This try/except block is an attempt to get more information about this occasional error: 
+        
+        ```bash
+        Traceback (most recent call last):
+        File "/home/ubuntu/github/virtualenvs/hosted/lib/python3.11/site-packages/billiard/pool.py", line 366, in workloop
+            put((READY, (job, i, result, inqW_fd)))
+        File "/home/ubuntu/github/virtualenvs/hosted/lib/python3.11/site-packages/billiard/queues.py", line 366, in put
+            self.send_payload(ForkingPickler.dumps(obj))
+                            ^^^^^^^^^^^^^^^^^^^^^^^^^
+        File "/home/ubuntu/github/virtualenvs/hosted/lib/python3.11/site-packages/billiard/reduction.py", line 56, in dumps
+            cls(buf, protocol).dump(obj)
+        billiard.pool.MaybeEncodingError: Error sending result: ''(1, <ExceptionInfo: MetadataException("\'checks\' | Additional metadata: required_output: {}")>, None)''. Reason: ''PicklingError("Can\'t pickle <class \'augur.tasks.util.metadata_exception.MetadataException\'>: it\'s not the same object as augur.tasks.util.metadata_exception.MetadataException")''.
+        ```
+    """

augur/tasks/git/util/facade_worker/facade_worker/analyzecommit.py

@@ -179,10 +179,13 @@ def generate_commit_record(repos_id,commit,filename,
 	#db_local.commit()
 	execute_sql(store_working_commit)
 
+	# commit_message = check_output(
+	# 	f"git --git-dir {repo_loc} log --format=%B -n 1 {commit}".split()
+	# ).strip()
+	
 	commit_message = check_output(
 		f"git --git-dir {repo_loc} log --format=%B -n 1 {commit}".split()
-	).strip()
-	
+	).decode('utf-8').strip()
 
 	msg_record = {
 		'repo_id' : repo_id,

augur/tasks/github/contributors.py

@@ -1,5 +1,6 @@
 import time
 import logging
+import traceback 
 
 from augur.tasks.init.celery_app import celery_app as celery
 from augur.tasks.init.celery_app import AugurCoreRepoCollectionTask

augur/tasks/github/detect_move/core.py

@@ -115,7 +115,7 @@ def ping_github_for_repo_move(session, key_auth, repo, logger,collection_hook='c
 
 
         session.commit()
-        raise Exception("ERROR: Repo has moved! Resetting Collection!")
+        raise Exception("ERROR: Repo has moved, and there is no redirection! 404 returned, not 301. Resetting Collection!")
 
 
     if attempts >= 10: