Skip to content

Conversation

kathayl
Copy link
Contributor

@kathayl kathayl commented May 5, 2025

add browser.close()

Summary

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

add browser.close()
@kathayl kathayl requested review from mchenco, celso, danielgek and a team as code owners May 5, 2025 22:48
Copy link
Contributor

hyperlint-ai bot commented May 5, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated the PDF generation documentation to include the closing of the browser after generating the PDF.

  • Added a call to close the browser after PDF generation
  • Improved resource management in the PDF generation process

Modified Files

  • src/content/docs/browser-rendering/how-to/pdf-generation.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@daisyfaithauma daisyfaithauma merged commit 89e4fed into production May 8, 2025
13 checks passed
@daisyfaithauma daisyfaithauma deleted the kathayl-patch-9 branch May 8, 2025 08:26
daisyfaithauma pushed a commit that referenced this pull request May 8, 2025
Maddy-Cloudflare pushed a commit that referenced this pull request May 9, 2025
daisyfaithauma pushed a commit that referenced this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants