Skip to content

Commit 7900c98

Browse files
committed
implement Matt's review comments
1 parent 9fc1236 commit 7900c98

1 file changed

Lines changed: 13 additions & 16 deletions

File tree

photon-client/src/components/cameras/CameraCalibrationCard.vue

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,10 @@ const getUniqueVideoFormatsByResolution = (): VideoFormat[] => {
4646
else format.mean = NaN;
4747
4848
// minPixelCount is the total area, in pixels, of the 640x480 (the minimum for proper calibration) resolution
49-
const minPixelCount = ref(307200);
50-
const resArea = computed(() => {
51-
return format.resolution.width * format.resolution.height;
52-
});
53-
if (resArea.value > minPixelCount.value) {
49+
const minPixelCount = 307200;
50+
const resArea = format.resolution.width * format.resolution.height;
51+
52+
if (resArea > minPixelCount) {
5453
format.resolution.width = 640;
5554
format.resolution.height = 480;
5655
uniqueResolutions.push(format);
@@ -191,17 +190,15 @@ const isCalibrating = computed(
191190
);
192191
193192
const startCalibration = () => {
194-
{
195-
useCameraSettingsStore().startPnPCalibration({
196-
squareSizeIn: squareSizeIn.value,
197-
markerSizeIn: markerSizeIn.value,
198-
patternHeight: patternHeight.value,
199-
patternWidth: patternWidth.value,
200-
boardType: boardType.value,
201-
useOldPattern: useOldPattern.value,
202-
tagFamily: tagFamily.value
203-
});
204-
}
193+
useCameraSettingsStore().startPnPCalibration({
194+
squareSizeIn: squareSizeIn.value,
195+
markerSizeIn: markerSizeIn.value,
196+
patternHeight: patternHeight.value,
197+
patternWidth: patternWidth.value,
198+
boardType: boardType.value,
199+
useOldPattern: useOldPattern.value,
200+
tagFamily: tagFamily.value
201+
});
205202
// The Start PnP method already handles updating the backend so only a store update is required
206203
useCameraSettingsStore().currentCameraSettings.currentPipelineIndex = WebsocketPipelineType.Calib3d;
207204
// isCalibrating.value = true;

0 commit comments

Comments
 (0)