Skip to content

Commit 9c22529

Browse files
Merge pull request #37 from dfki-ric/fix-qt4-only-build
Switch to RockQt macros, only build if all Qt deps are available
2 parents 360eff6 + ebf82d7 commit 9c22529

File tree

1 file changed

+47
-79
lines changed

1 file changed

+47
-79
lines changed

src/gui/CMakeLists.txt

Lines changed: 47 additions & 79 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,7 @@
11
rock_find_qt4(OPTIONAL)
22
rock_find_qt5(OPTIONAL)
33

4-
pkg_check_modules(vizkit3d vizkit3d)
5-
pkg_check_modules(vizkit3d-qt5 vizkit3d-qt5)
6-
7-
pkg_check_modules(vizkit3d_debug_drawings vizkit3d_debug_drawings)
8-
pkg_check_modules(vizkit3d_debug_drawings-qt5 vizkit3d_debug_drawings-qt5)
9-
10-
pkg_check_modules(maps-viz maps-viz)
11-
pkg_check_modules(maps-viz-qt5 maps-viz-qt5)
12-
13-
pkg_check_modules(base-viz base-viz)
14-
pkg_check_modules(base-viz-qt5 base-viz-qt5)
4+
include(RockQt)
155

166
find_package(PCL 1.7 REQUIRED COMPONENTS common io)
177
IF("${PCL_VERSION_MAJOR}.${PCL_VERSION_MINOR}" VERSION_LESS 1.14)
@@ -20,49 +10,61 @@ ENDIF()
2010

2111
if(ENABLE_DEBUG_DRAWINGS AND vizkit3d_debug_drawings-commands_FOUND)
2212
# These are (only) required for building the GUIs:
23-
if(vizkit3d_debug_drawings_FOUND)
24-
list(APPEND DEPS_PKGCONFIG_QT4 vizkit3d_debug_drawings)
25-
endif()
26-
if(vizkit3d_debug_drawings-qt5_FOUND)
27-
list(APPEND DEPS_PKGCONFIG_QT5 vizkit3d_debug_drawings-qt5)
28-
endif()
13+
list(APPEND DEPS_PKGCONFIG_QT vizkit3d_debug_drawings)
2914
endif()
3015

31-
if(ROCK_QT_VERSION_4 AND vizkit3d_FOUND AND maps-viz_FOUND AND base-viz_FOUND)
32-
rock_library(ugv_nav4d_gui
33-
SOURCES
34-
PlannerGui.cpp
35-
HEADERS
36-
PlannerGui.h
37-
MOC
38-
PlannerGui.h
39-
DEPS ugv_nav4d Qt4::QtCore
40-
DEPS_PKGCONFIG vizkit3d
16+
rock_qt_library(
17+
TARGETPREFIX ugv_nav4d_gui
18+
QT4_SUFFIX ""
19+
MISSINGQTDEPS_NOBUILD
20+
SOURCES
21+
PlannerGui.cpp
22+
HEADERS
23+
PlannerGui.h
24+
MOC
25+
PlannerGui.h
26+
DEPS ugv_nav4d
27+
DEPS_QT4 Qt4::QtCore
28+
DEPS_QT5 Qt5::Core
29+
DEPS_PKGCONFIG
30+
base-types
31+
pcl_common${PCL_VERSION_SUFFIX}
32+
pcl_io${PCL_VERSION_SUFFIX}
33+
DEPS_PKGCONFIG_QT vizkit3d
4134
vizkit3d-viz
4235
traversability_generator3d-viz
4336
maps-viz
4437
base-viz
4538
sbpl_spline_primitives-viz
46-
base-types
4739
trajectory_follower-viz
48-
pcl_common${PCL_VERSION_SUFFIX}
49-
pcl_io${PCL_VERSION_SUFFIX}
50-
${DEPS_PKGCONFIG_QT4}
51-
)
40+
${DEPS_PKGCONFIG_QT}
41+
)
42+
43+
rock_qt_executable(
44+
TARGETPREFIX ugv_nav4d_bin
45+
QT4_SUFFIX ""
46+
MISSINGQTDEPS_NOBUILD
47+
SOURCES
48+
Main.cpp
49+
DEPS ugv_nav4d
50+
DEPS_QT ugv_nav4d_gui
51+
)
5252

53-
rock_executable(ugv_nav4d_bin
54-
SOURCES
55-
Main.cpp
56-
DEPS ugv_nav4d ugv_nav4d_gui
57-
)
53+
rock_qt_executable(
54+
TARGETPREFIX ugv_nav4d_replay
55+
QT4_SUFFIX ""
56+
MISSINGQTDEPS_NOBUILD
57+
SOURCES
58+
ReplayDump.cpp
59+
DEPS ugv_nav4d
60+
DEPS_QT ugv_nav4d_gui
61+
DEPS_PKGCONFIG
62+
base-types
63+
DEPS_PKGCONFIG_QT vizkit3d maps-viz base-viz
64+
sbpl_spline_primitives-viz trajectory_follower-viz
65+
)
5866

59-
rock_executable(ugv_nav4d_replay
60-
SOURCES
61-
ReplayDump.cpp
62-
DEPS ugv_nav4d ugv_nav4d_gui
63-
DEPS_PKGCONFIG vizkit3d maps-viz base-viz
64-
sbpl_spline_primitives-viz base-types trajectory_follower-viz
65-
)
67+
if(TARGET ugv_nav4d_gui)
6668
if (ENABLE_DEBUG_DRAWINGS AND vizkit3d_debug_drawings-commands_FOUND AND vizkit3d_debug_drawings_FOUND)
6769
message(STATUS "Gui using Qt4: enabled, with debug drawings")
6870
else()
@@ -72,41 +74,7 @@ else(ROCK_QT_VERSION_4 AND vizkit3d_FOUND)
7274
message(STATUS "Gui using Qt4: disabled")
7375
endif(ROCK_QT_VERSION_4 AND vizkit3d_FOUND)
7476

75-
if(ROCK_QT_VERSION_5 AND vizkit3d-qt5_FOUND AND maps-viz-qt5_FOUND AND base-viz-qt5_FOUND)
76-
rock_library(ugv_nav4d_gui-qt5
77-
SOURCES
78-
PlannerGui.cpp
79-
HEADERS
80-
PlannerGui.h
81-
MOC5
82-
PlannerGui.h
83-
DEPS ugv_nav4d Qt5::Core
84-
DEPS_PKGCONFIG vizkit3d-qt5
85-
vizkit3d-viz-qt5
86-
traversability_generator3d-viz-qt5
87-
maps-viz-qt5
88-
base-viz-qt5
89-
sbpl_spline_primitives-viz-qt5
90-
base-types
91-
trajectory_follower-viz-qt5
92-
pcl_common${PCL_VERSION_SUFFIX}
93-
pcl_io${PCL_VERSION_SUFFIX}
94-
${DEPS_PKGCONFIG_QT5}
95-
)
96-
97-
rock_executable(ugv_nav4d_bin-qt5
98-
SOURCES
99-
Main.cpp
100-
DEPS ugv_nav4d ugv_nav4d_gui-qt5
101-
)
102-
103-
rock_executable(ugv_nav4d_replay-qt5
104-
SOURCES
105-
ReplayDump.cpp
106-
DEPS ugv_nav4d ugv_nav4d_gui-qt5
107-
DEPS_PKGCONFIG vizkit3d-qt5 maps-viz-qt5 base-viz-qt5
108-
sbpl_spline_primitives-viz-qt5 base-types trajectory_follower-viz-qt5
109-
)
77+
if(TARGET ugv_nav4d_gui-qt5)
11078
if (ENABLE_DEBUG_DRAWINGS AND vizkit3d_debug_drawings-commands_FOUND AND vizkit3d_debug_drawings-qt5_FOUND)
11179
message(STATUS "Gui using Qt5: enabled, with debug drawings")
11280
else()

0 commit comments

Comments
 (0)