Merge pull request #122 from rainers/master

Visual D 0.51.0

Author: rainers

CHANGES

@@ -1175,20 +1175,33 @@ Version history
   * VS 2019 16.2: command line options no longer read correctly from the VC project for
     Compile and Run/Debug/Disassemble, dbuild refactored to not rely on msbuild DLLs for that
 
-unreleased Version 0.51.0
-  * Ctrl+Click goto definition added for VS2017+
-  * experimental: semantic server built from dmd frontend
-  * VS2017+: syntax highlighted tool tips
+2020-01-18 Version 0.51.0
+  * installer:
+    - add sections for "Build Tools VS2017/2019"
+    - support more legacy Windows SDKs
+    - full installer now bundled with DMD 2.090 and LDC 1.19
+  * editor:
+    - added option to not show error squiggles and markers
+    - Ctrl+Click goto definition added for VS2017+
+    - VS2017+: syntax highlighted tool tips
+    - added tooltip to collapsed region
+    - fix function signature tool tips
+    - synchronize known version identifiers with dmd 2.090
+  * semantic server
+    - experimental: semantic server built from dmd frontend
+    - now creates server process per Visual Studio instance
+    - improve recovery after semantic server is restarted
+    - error list now filled with intellisense errors
+  * projects:
+    - visualdproj basic DUB support: upgrade and refresh if project contains dub.json or dub.sdl
+    - msbuild: pass original variable LinkToolExe to pipelink.exe through environment
+    - msbuild: fixed dependency project being marked as "unsuccessfully built" when detecting
+      D library requirements
+    - removed support for -gc (no longer supported since dmd 2.083)
   * mago:
     - new option "hide reference pointers"
-	- new option: "remove leading zeroes from hex values"
-	- fix crash expanding pointer to empty dynamic array
-	- large arrays: show growing index, fix omitting last element
-  * installer: add sections for "Build Tools VS2017/2019""
-  * dparser: now creates server process per Visual Studio instance
-  * added option to not show error squiggles and markers
-  * added tooltip to collapsed region
-  * fix function signature tool tips
-  * error list now filled with intellisense errors
-  * basic DUB support: upgrade and refresh if project contains dub.json or dub.sdl
-  * msbuild: pass original variable LinkToolExe to pipelink.exe through environment
+    - new option: "remove leading zeroes from hex values"
+    - fix crash expanding pointer to empty dynamic array
+    - large arrays: show growing index, fix omitting last element
+    - improve AA version detection, adapt to modified hash function
+    - VS2019 16.4: fix "Error" shown in tooltip for array elements beyond the actual size

VERSION

@@ -1,5 +1,5 @@
 #define VERSION_MAJOR      0
 #define VERSION_MINOR      51
 #define VERSION_REVISION   0
-#define VERSION_BETA       -beta
-#define VERSION_BUILD      1
+#define VERSION_BETA       
+#define VERSION_BUILD      0

c2d/tokutil.d

@@ -1172,10 +1172,10 @@ void regexReplacePPdefines(TokenList srctokens, string[string] defines)
 						endIt.retreat();
 						posttext = endIt.pretext ~ endIt.text ~ posttext;
 					}
-					string text = tokenListToString(tokIt + 2, endIt);
+					string toktext = tokenListToString(tokIt + 2, endIt);
 					string txt = s;
 					txt = replace(txt, "$id", ident);
-					txt = replace(txt, "$text", text);
+					txt = replace(txt, "$text", toktext);
 					it.pretext ~= tokIt.pretext;
 					it.text = txt ~ posttext;
 					it.type = Token.PPinsert;

c2d/vsi2d.visualdproj

@@ -1002,7 +1002,7 @@
   <useArrayBounds>0</useArrayBounds>
   <boundscheck>0</boundscheck>
   <useSwitchError>0</useSwitchError>
-  <useUnitTests>1</useUnitTests>
+  <useUnitTests>0</useUnitTests>
   <useInline>0</useInline>
   <release>0</release>
   <preservePaths>0</preservePaths>

doc/StartPage.dd

@@ -84,6 +84,13 @@ $(H2 News)
 $(P $(LINK2 VersionHistory.html, Full version history and complete details...)
 )
 
+2020-18-01 Version 0.51.0
+$(UL
+ $(LI experimental: semantic server built from DMD frontend)
+ $(LI VS2017+: Ctrl+Click goto definition added)
+ $(LI VS2017+: syntax highlighted tool tips)
+)
+
 2019-09-03 Version 0.50.1
 $(UL
  $(LI Fixes some integration issues with VS 2019 16.2)
@@ -100,27 +107,6 @@ $(UL
  $(LI highlight references to symbol at caret)
 )
 
-2019-04-28 Version 0.49.2
-$(UL
- $(LI VS2013/VS2015: VC projects broken in 0.49.1 due to unsupported msbuild variable)
- $(LI VS2015: workaround VS not correctly updating extension caches after uninstallation)
-)
-
-2019-04-21 Version 0.49.1
-$(UL
-  $(LI fixed reading settings from VC projects in VS2017)
-  $(LI added support for VS2019 Update 16.1)
-  $(LI dparser improvements and bug fixes)
-)
-
-2019-04-07 Version 0.49.0
-$(UL
-  $(LI support for Visual Studio 2019)
-  $(LI parallel compilation supported by VC projects (thanks to Igor Cesi))
-  $(LI catch up with recent language changes)
-  $(LI new "Language" configuration page for -transition=/-preview=/-revert= options)
-)
-
 $(LINK2 VersionHistory.html, more...)
 
 $(H2 Download)

doc/VersionHistory.dd

@@ -1,5 +1,47 @@
 Ddoc
 
+$(H2 2020-01-18 Version 0.51.0)
+ $(UL
+  $(LI installer:
+   $(UL
+    $(LI add sections for "Build Tools VS2017/2019")
+    $(LI support more legacy Windows SDKs)
+  ))
+  $(LI editor:
+   $(UL
+    $(LI Ctrl+Click goto definition added for VS2017+)
+    $(LI VS2017+: syntax highlighted tool tips)
+    $(LI added tooltip to collapsed region)
+    $(LI added option to not show error squiggles and markers)
+    $(LI fix function signature tool tips)
+    $(LI synchronize known version identifiers with dmd 2.090)
+  ))
+  $(LI semantic server
+   $(UL
+    $(LI experimental: semantic server built from DMD frontend)
+    $(LI now creates server process per Visual Studio instance)
+    $(LI improve recovery after semantic server is restarted)
+    $(LI error list now filled with intellisense errors)
+  ))
+  $(LI projects:
+   $(UL
+    $(LI visualdproj basic DUB support: upgrade and refresh if project contains dub.json or dub.sdl)
+    $(LI msbuild: pass original variable LinkToolExe to pipelink.exe through environment)
+    $(LI msbuild: fixed dependency project being marked as "unsuccessfully built" when detecting
+      D library requirements)
+    $(LI removed support for -gc (no longer supported since dmd 2.083))
+  ))
+  $(LI mago:
+   $(UL
+    $(LI new option "hide reference pointers")
+    $(LI new option: "remove leading zeroes from hex values")
+    $(LI fix crash expanding pointer to empty dynamic array)
+    $(LI large arrays: show growing index, fix omitting last element)
+    $(LI improve AA version detection, adapt to modified hash function)
+    $(LI VS2019 16.4: fix "Error" shown in tooltip for array elements beyond the actual size)
+  ))
+ )
+
 $(H2 2019-09-03 Version 0.50.1)
  $(UL
   $(LI installer:
@@ -32,7 +74,7 @@ $(H2 2019-09-03 Version 0.50.1)
       $(LI display of delegate type)
       $(LI support arbitrary return types)
     ))
-	$(LI fix showing UTF32 values (supported by dmd 2.089))
+    $(LI fix showing UTF32 values (supported by dmd 2.089))
     $(LI fix reading enum values (not emitted before dmd 2.089))
   ))
  )

doc/visuald.ddoc

@@ -1,6 +1,6 @@
-VERSION = 0.50.1
-DMD_VERSION = 2.087.1
-LDC_VERSION = 1.17.0
+VERSION = 0.51.0
+DMD_VERSION = 2.090.0
+LDC_VERSION = 1.19.0
 ROOT_DIR = https://www.dlang.org/
 ROOT = https://www.dlang.org
 BODYCLASS = visuald

msbuild/dbuild/CompileDOpt.cs

@@ -421,7 +421,7 @@ public string DebugInfo
                 string[][] switchMap = new string[3][]
                 {
                     new string[2] { "None", "" },
-                    new string[2] { "VS", "-gc" },
+                    new string[2] { "VS", "-g" },  // -gc removed, but kept for compatibility
                     new string[2] { "Mago", "-g" }
                 };
 

msbuild/dbuild/VCProjectInterop.cs

@@ -40,7 +40,8 @@ public partial class VisualCHelper : IVisualCHelper
     {
         ///////////////////////////////////////////////////////////////////////
         static int ConfigureFlags(bool unittestOn, bool debugOn, bool x64, bool cov, bool doc, bool nobounds, bool gdc,
-                                  int versionLevel, int debugLevel, bool noDeprecated, bool ldc, bool warnings)
+                                  int versionLevel, int debugLevel, bool noDeprecated, bool deprecateInfo,
+                                  bool ldc, bool warnings, bool warnAsError)
         {
             return (unittestOn ? 1 : 0)
                 | (debugOn ? 2 : 0)
@@ -50,10 +51,12 @@ static int ConfigureFlags(bool unittestOn, bool debugOn, bool x64, bool cov, boo
                 | (nobounds ? 32 : 0)
                 | (gdc ? 64 : 0)
                 | (noDeprecated ? 128 : 0)
+                | (deprecateInfo ? 0x40000000 : 0)
                 | ((versionLevel & 0xff) << 8)
                 | ((debugLevel & 0xff) << 16)
                 | (ldc ? 0x4000000 : 0)
-                | (warnings ? 0x10000000 : 0);
+                | (warnings ? 0x10000000 : 0)
+                | (warnAsError ? 0x20000000 : 0);
         }
 
 
@@ -207,13 +210,16 @@ public void GetDCompileOptions(IVsHierarchy proj, uint itemid,
             bool cov = vcprop.GetEvaluatedPropertyValue("Coverage") == "true";
             bool doc = vcprop.GetEvaluatedPropertyValue("DocDir") != "" || vcprop.GetEvaluatedPropertyValue("DocFile") != "";
             bool nobounds = vcprop.GetEvaluatedPropertyValue("BoundsCheck") == "On";
-            bool noDeprecated = vcprop.GetEvaluatedPropertyValue("Deprecations") == "Error";
+            bool noDeprecated = vcprop.GetEvaluatedPropertyValue("Deprecations") != "Allow";
+            bool deprecatedInfo = vcprop.GetEvaluatedPropertyValue("Deprecations") == "Info";
             bool warnings = vcprop.GetEvaluatedPropertyValue("Warnings") != "None";
+            bool warnAsError = vcprop.GetEvaluatedPropertyValue("Warnings") == "Error";
             bool gdc = false;
             int versionLevel = 0;
             int debugLevel = 0;
             flags = (uint)ConfigureFlags(unittestOn, debugOn, x64, cov, doc, nobounds, gdc,
-                                         versionLevel, debugLevel, noDeprecated, ldc, warnings);
+                                         versionLevel, debugLevel, noDeprecated, deprecatedInfo,
+                                         ldc, warnings, warnAsError);
         }
 
 

msbuild/dcompile.targets

@@ -38,15 +38,18 @@
   </UsingTask>
 
   <!-- remove disabled files from DCompile -->
-  <Target Name="_collectDFiles"
-    DependsOnTargets="_SelectedFiles">
-    
+  <Target Name="_collectDFiles">
+
+    <ItemGroup>
+      <dcompile_SelectedFiles Include="$(SelectedFiles)"/>
+    </ItemGroup>
+
     <ItemGroup Condition="'$(DCompiler)' == 'None'">
       <DCompile Remove="@(DCompile)" />
     </ItemGroup>
 
-    <ItemGroup Condition="'@(SelectedFiles)' != ''">
-      <DCompile Remove="@(DCompile)" Condition="'%(Identity)' != '@(SelectedFiles)'" />
+    <ItemGroup Condition="'@(dcompile_SelectedFiles)' != ''">
+      <DCompile Remove="@(DCompile)" Condition="'%(Identity)' != '@(dcompile_SelectedFiles)'" />
     </ItemGroup>
 
     <ItemGroup>
@@ -127,10 +130,10 @@
     BeforeTargets="$(DCompileBeforeTargets)"
     AfterTargets="$(DCompileAfterTargets)"
     Condition="'@(DCompile)' != '' and '$(DCompiler)' != 'None'"
-    DependsOnTargets="_collectDFiles;_replacePackageName;_SelectedFiles">
+    DependsOnTargets="_collectDFiles;_replacePackageName">
 
-    <ItemGroup Condition="'@(SelectedFiles)' != ''">
-      <DCompile Remove="@(DCompile)" Condition="'%(Identity)' != '@(SelectedFiles)'" />
+    <ItemGroup Condition="'@(dcompile_SelectedFiles)' != ''">
+      <DCompile Remove="@(DCompile)" Condition="'%(Identity)' != '@(dcompile_SelectedFiles)'" />
     </ItemGroup>
 
     <PropertyGroup>