can't import both StopPlaces and Parkings referring to each other in one go

[esuomi]

This is kind of a logical trap which in its current form blocks importing both StopPlaces and Parkings in one go.

What happens is that since import reassigns NeTEx id:s for all entities, one cannot know beforehand what the id:s will be and thus there isn't a valid parentSiteRef for Parking at time of creation - unless by accident at which point the Parking gets added to wrong Site, as it's relatively easy to believe that the stable NeTEx id given to the ref is the same as earlier defined in the same file.

To make this work in expected manner, the import should probably allow referring to StopPlace's imported-id key value property in place of the parentSiteRef. This is probably OK, as the Site > ParentSiteRef documentation simply states

Value dependent on context.

Alternatively to get this working as expected we'd need to split the import to two separate files, but as it's about the same effort to

1. Import StopPlaces
2. Get generated NeTEx id:s for imported StopPlaces
3. Remap parkings list with correct id references
   as to
4. Import StopPlaces
5. Use the UI to insert Parking information

the import for parkings is somewhat infeasible for us at the moment.

Relevant lookup logic here: ParkingVersionedSaverService.java#L104-L114

[solita-topip]

During INITIAL import the NeTEx ids of both StopPlace and Parking remain stable. But if Parking has parentSiteRef defined with version the following exception is thrown:

java.lang.NullPointerException: Cannot invoke "org.rutebanken.tiamat.model.DataManagedObjectStructure.getNetexId()" because "referencedStopPlace" is nul

What actually happens is that during import Tiamat will increase the version for each imported Element. Thus this leads to the reference becoming invalid as the referenced version of the Element does not exists after import (version=1 in XML, version=2 in Tiamat DB).

The issue can be reproduced with the file below

<PublicationDelivery xmlns="http://www.netex.org.uk/netex" xmlns:ns2="http://www.opengis.net/gml/3.2" xmlns:ns3="http://www.siri.org.uk/siri" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.12:NO-NeTEx-stops:1.4" xsi:schemaLocation="">
    <PublicationTimestamp>2025-08-21T13:10:53.599</PublicationTimestamp>
    <ParticipantRef>NSR</ParticipantRef>
    <dataObjects>
        <SiteFrame modification="new" version="1" id="NSR:SiteFrame:1671890196">
            <FrameDefaults>
                <DefaultLocale>
                    <TimeZone>Europe/Helsinki</TimeZone>
                    <DefaultLanguage>eng</DefaultLanguage>
                </DefaultLocale>
            </FrameDefaults>
            <stopPlaces>
                <StopPlace created="2025-08-21T13:09:58.402" changed="2025-08-21T13:10:50.873" modification="new" version="1" id="NSR:StopPlace:100">
                    <ValidBetween>
                        <FromDate>2025-08-21T13:10:50.873</FromDate>
                    </ValidBetween>
                    <Name lang="en">Stopplace 1</Name>
                    <PrivateCode/>
                    <Centroid>
                        <Location>
                            <Longitude>0</Longitude>
                            <Latitude>0</Latitude>
                        </Location>
                    </Centroid>
                    <TransportMode>bus</TransportMode>
                    <OtherTransportModes/>
                    <StopPlaceType>onstreetBus</StopPlaceType>
                    <Weighting>interchangeAllowed</Weighting>
                </StopPlace>
            </stopPlaces>
            <parkings>
                <Parking created="2025-08-21T13:10:51.081" modification="new" version="1" id="NSR:Parking:12">
                    <Name lang="en">Park and ride</Name>
                    <ParentSiteRef ref="NSR:StopPlace:100" version="1" />
                    <ParkingVehicleTypes>car</ParkingVehicleTypes>
                    <TotalCapacity>201</TotalCapacity>
                    <ParkingPaymentProcess/>
                    <parkingProperties>
                        <ParkingProperties version="0" id="NSR:ParkingProperties:1">
                            <ParkingUserTypes/>
                            <spaces>
                                <ParkingCapacity version="0" id="NSR:ParkingCapacity:1">
                                    <ParkingUserType>allUsers</ParkingUserType>
                                    <NumberOfSpaces>100</NumberOfSpaces>
                                </ParkingCapacity>
                                <ParkingCapacity version="0" id="NSR:ParkingCapacity:2">
                                    <ParkingUserType>registeredDisabled</ParkingUserType>
                                    <NumberOfSpaces>101</NumberOfSpaces>
                                </ParkingCapacity>
                            </spaces>
                        </ParkingProperties>
                    </parkingProperties>
                </Parking>
            </parkings>
        </SiteFrame>
    </dataObjects>
</PublicationDelivery>

Temporary fix

Without the version-tag in ParentSiteRef-element the import succeeds. That is because without the version ReferenceResolver resolves to the latest version of the referenced Element

tiamat/src/main/java/org/rutebanken/tiamat/repository/reference/ReferenceResolver.java

Lines 82 to 87 in 105d21a

	if (versionOfObjectRefStructure.getVersion() == null) {
	return genericEntityInVersionRepository.findFirstByNetexIdOrderByVersionDesc(netexId, clazz);
	} else {
	long version = Long.valueOf(versionOfObjectRefStructure.getVersion());
	return genericEntityInVersionRepository.findFirstByNetexIdAndVersion(netexId, version, clazz);
	}

// Does not work
<ParentSiteRef ref="NSR:StopPlace:100" version="1" />

// Does work
<ParentSiteRef ref="NSR:StopPlace:100" />
<ParentSiteRef ref="NSR:StopPlace:100" version="2" />