Skip to content

Simon's code review #52

@simonryrie

Description

@simonryrie

This project is really impressive, amazing work! The core functionality is great and I love the design.

UX:



As someone loading the site for the first time, it might be nice to be taken straight to the canvas rather than an empty gallery.

Caption positioning - should it be below the images in the gallery? It also seems to be affecting the image positioning which can push the images out of their containers (this was when I was messing around with adding tags so maybe would be fixed with sanitisation).

Responsiveness on gallery with flex works pretty well - it might be nice to have some media queries for the canvas page for mobile and tablet.

Functionality:



Sanitisation - I was able to pass HTML e.g. h1, a tags as captions. Should this be sanitised?

Code:



I like that you had a layout template to reduce duplication but see it was commented out - was there a reason for this?

Prettier doesn't seem to have applied properly to some of the templates files which can make the indentation a bit confusing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions