fix(connect): require confirmation on destroy apis

Author: TillaTheHun0

packages/connect/deno/services/cache.ts

@@ -46,7 +46,7 @@ export const query = (pattern = '*') => (h: HyperRequestFunction) =>
 
 export const create = () => (hyper: HyperRequestFunction) => hyper({ service, method: Method.PUT })
 
-export const destroy = (confirm = true) => (hyper: HyperRequestFunction) =>
+export const destroy = (confirm?: boolean) => (hyper: HyperRequestFunction) =>
   confirm
     ? hyper({ service, method: Method.DELETE })
     : Promise.reject({ ok: false, msg: 'request not confirmed!' })

packages/connect/deno/services/data.ts

@@ -65,7 +65,7 @@ export const index = (
 
 export const create = () => (hyper: HyperRequestFunction) => hyper({ service, method: Method.PUT })
 
-export const destroy = (confirm = true) => (hyper: HyperRequestFunction) =>
+export const destroy = (confirm?: boolean) => (hyper: HyperRequestFunction) =>
   confirm
     ? hyper({ service, method: Method.DELETE })
     : Promise.reject({ ok: false, msg: 'request not confirmed!' })

packages/connect/deno/services/search.ts

@@ -36,7 +36,7 @@ export const load = (docs: unknown[]) => (hyper: HyperRequestFunction) =>
 export const create = (fields: string[], storeFields?: string[]) => (hyper: HyperRequestFunction) =>
   hyper({ service, method: Method.PUT, body: { fields, storeFields } })
 
-export const destroy = (confirm = true) => (hyper: HyperRequestFunction) =>
+export const destroy = (confirm?: boolean) => (hyper: HyperRequestFunction) =>
   confirm
     ? hyper({ service, method: Method.DELETE })
     : Promise.reject({ ok: false, msg: 'request not confirmed!' })

packages/connect/deno/tests/cache.test.ts

@@ -1,5 +1,5 @@
 import { HyperRequest } from '../types.ts'
-import { assertEquals } from '../dev_deps.ts'
+import { assert, assertEquals } from '../dev_deps.ts'
 
 import { add, create, destroy, get, query, remove, set } from '../services/cache.ts'
 import { HYPER_LEGACY_GET_HEADER } from '../utils/hyper-request.ts'
@@ -96,4 +96,10 @@ test('cache.destroy', async () => {
   }
 
   await destroy(true)(mockRequest)
+
+  const noConfirmRequest = (_h: HyperRequest) => {
+    assert(false, 'unreachable')
+  }
+
+  await destroy()(noConfirmRequest).catch(assert)
 })

packages/connect/deno/tests/data.test.ts

@@ -1,6 +1,6 @@
 import { HyperRequest } from '../types.ts'
 
-import { assertEquals } from '../dev_deps.ts'
+import { assert, assertEquals } from '../dev_deps.ts'
 
 import { add, bulk, create, destroy, get, index, query, remove, update } from '../services/data.ts'
 import { HYPER_LEGACY_GET_HEADER } from '../utils/hyper-request.ts'
@@ -154,4 +154,10 @@ test('data.destroy', async () => {
   }
 
   await destroy(true)(mockRequest)
+
+  const noConfirmRequest = (_h: HyperRequest) => {
+    assert(false, 'unreachable')
+  }
+
+  await destroy()(noConfirmRequest).catch(assert)
 })

packages/connect/deno/tests/search.test.ts

@@ -1,6 +1,6 @@
 import { HyperRequest } from '../types.ts'
 
-import { assertEquals } from '../dev_deps.ts'
+import { assert, assertEquals } from '../dev_deps.ts'
 
 import { add, create, destroy, get, load, query, remove, update } from '../services/search.ts'
 
@@ -127,4 +127,10 @@ test('search.destroy', async () => {
   }
 
   await destroy(true)(mockRequest)
+
+  const noConfirmRequest = (_h: HyperRequest) => {
+    assert(false, 'unreachable')
+  }
+
+  await destroy()(noConfirmRequest).catch(assert)
 })