fix(connect): require destroy confirmation to be strictly true

Author: TillaTheHun0

packages/connect/deno/services/cache.ts

@@ -47,6 +47,6 @@ export const query = (pattern = '*') => (h: HyperRequestFunction) =>
 export const create = () => (hyper: HyperRequestFunction) => hyper({ service, method: Method.PUT })
 
 export const destroy = (confirm?: boolean) => (hyper: HyperRequestFunction) =>
-  confirm
+  confirm === true
     ? hyper({ service, method: Method.DELETE })
     : Promise.reject({ ok: false, msg: 'request not confirmed!' })

packages/connect/deno/services/data.ts

@@ -66,6 +66,6 @@ export const index = (
 export const create = () => (hyper: HyperRequestFunction) => hyper({ service, method: Method.PUT })
 
 export const destroy = (confirm?: boolean) => (hyper: HyperRequestFunction) =>
-  confirm
+  confirm === true
     ? hyper({ service, method: Method.DELETE })
     : Promise.reject({ ok: false, msg: 'request not confirmed!' })

packages/connect/deno/services/queue.ts

@@ -15,6 +15,6 @@ export const create = (target: string, secret?: string) => (hyper: HyperRequestF
   hyper({ service, method: Method.PUT, body: { target, secret } })
 
 export const destroy = (confirm?: boolean) => (hyper: HyperRequestFunction) =>
-  confirm
+  confirm === true
     ? hyper({ service, method: Method.DELETE })
     : Promise.reject({ ok: false, msg: 'request not confirmed!' })

packages/connect/deno/services/search.ts

@@ -37,6 +37,6 @@ export const create = (fields: string[], storeFields?: string[]) => (hyper: Hype
   hyper({ service, method: Method.PUT, body: { fields, storeFields } })
 
 export const destroy = (confirm?: boolean) => (hyper: HyperRequestFunction) =>
-  confirm
+  confirm === true
     ? hyper({ service, method: Method.DELETE })
     : Promise.reject({ ok: false, msg: 'request not confirmed!' })

packages/connect/deno/services/storage.ts

@@ -59,6 +59,6 @@ export const remove = (name: string) => (h: HyperRequestFunction) =>
 export const create = () => (hyper: HyperRequestFunction) => hyper({ service, method: Method.PUT })
 
 export const destroy = (confirm?: boolean) => (hyper: HyperRequestFunction) =>
-  confirm
+  confirm === true
     ? hyper({ service, method: Method.DELETE })
     : Promise.reject({ ok: false, msg: 'request not confirmed!' })

packages/connect/deno/tests/cache.test.ts

@@ -106,4 +106,6 @@ test('cache.destroy', async () => {
   }
 
   await destroy()(noConfirmRequest).catch(assert)
+  // @ts-expect-error testing runtime checks
+  await destroy('no-bool')(noConfirmRequest).catch(assert)
 })

packages/connect/deno/tests/data.test.ts

@@ -164,4 +164,6 @@ test('data.destroy', async () => {
   }
 
   await destroy()(noConfirmRequest).catch(assert)
+  // @ts-expect-error testing runtime checks
+  await destroy('no-bool')(noConfirmRequest).catch(assert)
 })

packages/connect/deno/tests/queue.test.ts

@@ -100,4 +100,6 @@ test('queue.destroy', async () => {
   }
 
   await destroy()(noConfirmRequest).catch(assert)
+  // @ts-expect-error testing runtime checks
+  await destroy('no-bool')(noConfirmRequest).catch(assert)
 })

packages/connect/deno/tests/search.test.ts

@@ -137,4 +137,6 @@ test('search.destroy', async () => {
   }
 
   await destroy()(noConfirmRequest).catch(assert)
+  // @ts-expect-error testing runtime checks
+  await destroy('no-bool')(noConfirmRequest).catch(assert)
 })

packages/connect/deno/tests/storage.test.ts

@@ -130,4 +130,6 @@ test('storage.destroy', async () => {
   }
 
   await destroy()(noConfirmRequest).catch(assert)
+  // @ts-expect-error testing runtime checks
+  await destroy('no-bool')(noConfirmRequest).catch(assert)
 })