Skip to content

Commit 6f37045

Browse files
arskaclaude
andcommitted
Fix globalResources env var names in Helm chart
The environment variables were missing underscores: - BACKUP_GLOBALCPU_REQUEST → BACKUP_GLOBAL_CPU_REQUEST - BACKUP_GLOBALMEMORY_REQUEST → BACKUP_GLOBAL_MEMORY_REQUEST - BACKUP_GLOBALCPU_LIMIT → BACKUP_GLOBAL_CPU_LIMIT - BACKUP_GLOBALMEMORY_LIMIT → BACKUP_GLOBAL_MEMORY_LIMIT Without the underscores, the operator doesn't recognize the variables and globalResources settings have no effect. Fixes #1069 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch>
1 parent 2a90b53 commit 6f37045

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

charts/k8up/templates/deployment.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,19 +50,19 @@ spec:
5050
fieldPath: metadata.namespace
5151
{{- end }}
5252
{{- with .Values.k8up.globalResources.requests.cpu }}
53-
- name: BACKUP_GLOBALCPU_REQUEST
53+
- name: BACKUP_GLOBAL_CPU_REQUEST
5454
value: {{ . }}
5555
{{- end }}
5656
{{- with .Values.k8up.globalResources.requests.memory }}
57-
- name: BACKUP_GLOBALMEMORY_REQUEST
57+
- name: BACKUP_GLOBAL_MEMORY_REQUEST
5858
value: {{ . }}
5959
{{- end }}
6060
{{- with .Values.k8up.globalResources.limits.cpu }}
61-
- name: BACKUP_GLOBALCPU_LIMIT
61+
- name: BACKUP_GLOBAL_CPU_LIMIT
6262
value: {{ . }}
6363
{{- end }}
6464
{{- with .Values.k8up.globalResources.limits.memory }}
65-
- name: BACKUP_GLOBALMEMORY_LIMIT
65+
- name: BACKUP_GLOBAL_MEMORY_LIMIT
6666
value: {{ . }}
6767
{{- end }}
6868
{{- if .Values.k8up.envVars }}

charts/k8up/test/deployment_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func Test_Deployment_ShouldRender_EnvironmentVariables(t *testing.T) {
4040
assert.Equal(t, "BACKUP_SKIP_WITHOUT_ANNOTATION", envs[3].Name)
4141
assert.Equal(t, "BACKUP_OPERATOR_NAMESPACE", envs[4].Name)
4242
assert.Equal(t, "metadata.namespace", envs[4].ValueFrom.FieldRef.FieldPath)
43-
assert.Equal(t, "BACKUP_GLOBALCPU_REQUEST", envs[5].Name, "Deployment does not use configured Env Name")
43+
assert.Equal(t, "BACKUP_GLOBAL_CPU_REQUEST", envs[5].Name, "Deployment does not use configured Env Name")
4444
assert.Equal(t, wantCpuRequest, envs[5].Value, "Deployment does not use configured Env Value")
4545
assert.Equal(t, "VARIABLE", envs[6].Name, "Deployment does not use configured Env Name")
4646
assert.Equal(t, "VALUE", envs[6].Value, "Deployment does not use configured Env Value")

0 commit comments

Comments
 (0)