-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
Closed
Labels
discussIssues opened for discussions and feedbacks.Issues opened for discussions and feedbacks.fsIssues and PRs related to the fs subsystem / file system.Issues and PRs related to the fs subsystem / file system.
Description
Hey, I was playing around with Object.seal()
and Object.freeze()
and discovered that internally Node is trying to modify my objects and I got the following in fs.watch
:
TypeError: Can't add property recursive, object is not extensible
In my opinion external objects should not be modified by Node, as I observed sometimes this rule is respected, sometimes - only partially (in case of fs.appendFile
).
Do we have anywhere this rule specified?
cc @nodejs/collaborators
andreiglingeanu, IvanGoncharov and sindresorhus
Metadata
Metadata
Assignees
Labels
discussIssues opened for discussions and feedbacks.Issues opened for discussions and feedbacks.fsIssues and PRs related to the fs subsystem / file system.Issues and PRs related to the fs subsystem / file system.