Skip to content

Commit e1967b7

Browse files
njmmatthieujdreo
authored andcommitted
fix: Nan for boolean and setting output to lower case for neo4j
1 parent 0ea9a8e commit e1967b7

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

src/ontoweaver/transformer.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1065,7 +1065,7 @@ class boolean(base.Transformer):
10651065

10661066
class ValueMaker(make_value.ValueMaker):
10671067

1068-
def __init__(self, raise_errors: bool = True, output_true = "True", output_false = "False", consider_true = None, consider_false = None):
1068+
def __init__(self, raise_errors: bool = True, output_true = "true", output_false = "false", consider_true = None, consider_false = None):
10691069
if (not consider_true and consider_false) or (consider_true and not consider_false):
10701070
msg = "I can only handle both `consider_true` and `consider_false` being `None` at the same time. But here, one of them is `None` and the other is not."
10711071
logger.error(msg)
@@ -1108,7 +1108,7 @@ def __init__(self, raise_errors: bool = True, output_true = "True", output_false
11081108
def __call__(self, columns, row, i):
11091109
for key in columns:
11101110
value = row[key]
1111-
if not value:
1111+
if np.isnan(value):
11121112
continue
11131113
value = str(value)
11141114

@@ -1136,8 +1136,8 @@ def __init__(self,
11361136
output_validator: validate.OutputValidator = None,
11371137
multi_type_dict = None,
11381138
raise_errors = True,
1139-
output_true = "True",
1140-
output_false = "False",
1139+
output_true = "true",
1140+
output_false = "false",
11411141
consider_true = None,
11421142
consider_false = None,
11431143
**kwargs

0 commit comments

Comments
 (0)