Sort imports, relocate Author static methods, add negative hint test

Author: lacatoire

src/DocBlock/StandardTagFactory.php

@@ -17,6 +17,7 @@
 use phpDocumentor\Reflection\DocBlock\Tags\Author;
 use phpDocumentor\Reflection\DocBlock\Tags\Covers;
 use phpDocumentor\Reflection\DocBlock\Tags\Deprecated;
+use phpDocumentor\Reflection\DocBlock\Tags\ExpectedFormat;
 use phpDocumentor\Reflection\DocBlock\Tags\Factory\AbstractPHPStanFactory;
 use phpDocumentor\Reflection\DocBlock\Tags\Factory\ExtendsFactory;
 use phpDocumentor\Reflection\DocBlock\Tags\Factory\Factory;
@@ -32,7 +33,6 @@
 use phpDocumentor\Reflection\DocBlock\Tags\Factory\TemplateFactory;
 use phpDocumentor\Reflection\DocBlock\Tags\Factory\ThrowsFactory;
 use phpDocumentor\Reflection\DocBlock\Tags\Factory\VarFactory;
-use phpDocumentor\Reflection\DocBlock\Tags\ExpectedFormat;
 use phpDocumentor\Reflection\DocBlock\Tags\Generic;
 use phpDocumentor\Reflection\DocBlock\Tags\InvalidTag;
 use phpDocumentor\Reflection\DocBlock\Tags\Link as LinkTag;

src/DocBlock/Tags/Author.php

@@ -29,16 +29,6 @@ final class Author extends BaseTag implements ExpectedFormat
     /** @var string register that this is the author tag. */
     protected string $name = 'author';
 
-    public static function getExpectedFormat(): string
-    {
-        return 'name [<email@example.com>]';
-    }
-
-    public static function getDocumentationUrl(): ?string
-    {
-        return 'https://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/author.html';
-    }
-
     /** @var string The name of the author */
     private string $authorName;
 
@@ -109,4 +99,14 @@ public static function create(string $body): ?self
 
         return new static($authorName, $email);
     }
+
+    public static function getExpectedFormat(): string
+    {
+        return 'name [<email@example.com>]';
+    }
+
+    public static function getDocumentationUrl(): ?string
+    {
+        return 'https://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/author.html';
+    }
 }

tests/unit/DocBlock/StandardTagFactoryTest.php

@@ -21,13 +21,13 @@
 use phpDocumentor\Reflection\Assets\CustomServiceInterface;
 use phpDocumentor\Reflection\Assets\CustomTagFactory;
 use phpDocumentor\Reflection\DocBlock\Tags\Author;
-use phpDocumentor\Reflection\DocBlock\Tags\InvalidTag;
 use phpDocumentor\Reflection\DocBlock\Tags\Deprecated;
 use phpDocumentor\Reflection\DocBlock\Tags\Extends_;
 use phpDocumentor\Reflection\DocBlock\Tags\Formatter;
 use phpDocumentor\Reflection\DocBlock\Tags\Formatter\PassthroughFormatter;
 use phpDocumentor\Reflection\DocBlock\Tags\Generic;
 use phpDocumentor\Reflection\DocBlock\Tags\Implements_;
+use phpDocumentor\Reflection\DocBlock\Tags\InvalidTag;
 use phpDocumentor\Reflection\DocBlock\Tags\Method;
 use phpDocumentor\Reflection\DocBlock\Tags\Mixin;
 use phpDocumentor\Reflection\DocBlock\Tags\Param;
@@ -158,6 +158,30 @@ public function testInvalidTagReceivesFormatHintFromHandler(): void
         $this->assertSame(Author::getDocumentationUrl(), $tag->getDocumentationUrl());
     }
 
+    /**
+     * @uses \phpDocumentor\Reflection\DocBlock\StandardTagFactory::addService
+     * @uses \phpDocumentor\Reflection\DocBlock\Tags\Generic
+     * @uses \phpDocumentor\Reflection\DocBlock\Tags\BaseTag
+     * @uses \phpDocumentor\Reflection\DocBlock\Tags\InvalidTag
+     *
+     * @covers ::__construct
+     * @covers ::create
+     */
+    public function testInvalidTagKeepsNullHintsWhenHandlerDoesNotAdvertiseAny(): void
+    {
+        $context    = new Context('');
+        $descriptionFactory = m::mock(DescriptionFactory::class);
+        $descriptionFactory->shouldReceive('create')->andThrow(new InvalidArgumentException('boom'));
+        $tagFactory = StandardTagFactory::createInstance(m::mock(FqsenResolver::class));
+        $tagFactory->addService($descriptionFactory, DescriptionFactory::class);
+
+        $tag = $tagFactory->create('@custom anything', $context);
+
+        $this->assertInstanceOf(InvalidTag::class, $tag);
+        $this->assertNull($tag->getExpectedFormat());
+        $this->assertNull($tag->getDocumentationUrl());
+    }
+
     /**
      * @uses \phpDocumentor\Reflection\DocBlock\StandardTagFactory::addService
      * @uses \phpDocumentor\Reflection\DocBlock\Tags\See