Skip to content

Commit a87ccec

Browse files
committed
chore: update methods
1 parent 7d3a1a2 commit a87ccec

File tree

3 files changed

+31
-20
lines changed

3 files changed

+31
-20
lines changed

packages/electron-chrome-extensions/src/browser-action.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -405,8 +405,8 @@ export const injectBrowserAction = () => {
405405
contextBridge.exposeInMainWorld('browserAction', __browserAction__)
406406

407407
// Must execute script in main world to modify custom component registry.
408-
;(contextBridge as any).evaluateInMainWorld({
409-
func: mainWorldScript
408+
;(contextBridge as any).executeInMainWorld({
409+
func: mainWorldScript,
410410
})
411411
} else {
412412
// When contextIsolation is disabled, contextBridge will throw an error.

packages/electron-chrome-extensions/src/browser/router.ts

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const getSessionFromEvent = (event: any): Electron.Session => {
2121
// TODO(mv3): add types
2222
const getHostFromEvent = (event: any) => {
2323
if (event.type === 'service-worker') {
24-
const serviceWorker = event.session.serviceWorkers.fromVersionID(event.versionId)
24+
const serviceWorker = event.session.serviceWorkers.getWorkerFromVersionID(event.versionId)
2525
return serviceWorker && !serviceWorker.isDestroyed() ? serviceWorker : null
2626
} else {
2727
return event.sender
@@ -72,7 +72,9 @@ class RoutingDelegate {
7272
const maybeListenForWorkerEvents = ({ runningStatus, versionId }: any) => {
7373
if (runningStatus !== 'starting') return
7474

75-
const serviceWorker = (observer.session as any).serviceWorkers.fromVersionID(versionId)
75+
const serviceWorker = (observer.session as any).serviceWorkers.getWorkerFromVersionID(
76+
versionId,
77+
)
7678
if (
7779
serviceWorker?.scope?.startsWith('chrome-extension://') &&
7880
!this.workers.has(serviceWorker)
@@ -209,15 +211,18 @@ export class ExtensionRouter {
209211
}
210212
})
211213

212-
session.serviceWorkers.on('running-status-changed' as any, ({ runningStatus, versionId }: any) => {
213-
if (runningStatus !== 'starting') return
214+
session.serviceWorkers.on(
215+
'running-status-changed' as any,
216+
({ runningStatus, versionId }: any) => {
217+
if (runningStatus !== 'starting') return
214218

215-
const serviceWorker = (session as any).serviceWorkers.fromVersionID(versionId)
216-
if (serviceWorker) {
217-
debug(`storing reference to background service worker [url:'${serviceWorker.scope}']`)
218-
this.extensionWorkers.add(serviceWorker)
219-
}
220-
})
219+
const serviceWorker = (session as any).serviceWorkers.getWorkerFromVersionID(versionId)
220+
if (serviceWorker) {
221+
debug(`storing reference to background service worker [url:'${serviceWorker.scope}']`)
222+
this.extensionWorkers.add(serviceWorker)
223+
}
224+
},
225+
)
221226
}
222227

223228
private filterListeners(predicate: (listener: EventListener) => boolean) {
@@ -380,7 +385,9 @@ export class ExtensionRouter {
380385

381386
if (host.constructor.name === 'ServiceWorkerMain') {
382387
if (host.isDestroyed()) {
383-
console.error(`Service Worker is destroyed.\nUnable to send '${eventName}' to extension host for ${extensionId}`)
388+
console.error(
389+
`Service Worker is destroyed.\nUnable to send '${eventName}' to extension host for ${extensionId}`,
390+
)
384391
return
385392
}
386393
host.startWorker().then(send)

packages/electron-chrome-extensions/src/renderer/index.ts

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ export const injectExtensionAPIs = () => {
158158
if (manifest.manifest_version === 3) {
159159
// TODO(mv3): might need to use offscreen document to serialize
160160
console.warn(
161-
'action.setIcon with imageData is not yet supported by electron-chrome-extensions'
161+
'action.setIcon with imageData is not yet supported by electron-chrome-extensions',
162162
)
163163
details.imageData = undefined
164164
} else if (details.imageData instanceof ImageData) {
@@ -169,7 +169,7 @@ export const injectExtensionAPIs = () => {
169169
obj[pair[0]] = imageData2base64(pair[1])
170170
return obj
171171
},
172-
{}
172+
{},
173173
)
174174
}
175175
}
@@ -314,11 +314,11 @@ export const injectExtensionAPIs = () => {
314314
...base,
315315
isAllowedFileSchemeAccess: invokeExtension('extension.isAllowedFileSchemeAccess', {
316316
noop: true,
317-
defaultResponse: false
317+
defaultResponse: false,
318318
}),
319319
isAllowedIncognitoAccess: invokeExtension('extension.isAllowedIncognitoAccess', {
320320
noop: true,
321-
defaultResponse: false
321+
defaultResponse: false,
322322
}),
323323
// TODO: Add native implementation
324324
getViews: () => [],
@@ -415,7 +415,11 @@ export const injectExtensionAPIs = () => {
415415
const api = {
416416
...base,
417417
create: invokeExtension('tabs.create'),
418-
executeScript: async function (arg1: unknown, arg2: unknown, arg3: unknown): Promise<any> {
418+
executeScript: async function (
419+
arg1: unknown,
420+
arg2: unknown,
421+
arg3: unknown,
422+
): Promise<any> {
419423
// Electron's implementation of chrome.tabs.executeScript is in
420424
// C++, but it doesn't support implicit execution in the active
421425
// tab. To handle this, we need to get the active tab ID and
@@ -541,8 +545,8 @@ export const injectExtensionAPIs = () => {
541545
contextBridge.exposeInMainWorld('electron', electronContext)
542546

543547
// Mutate global 'chrome' object with additional APIs in the main world.
544-
;(contextBridge as any).evaluateInMainWorld({
545-
func: mainWorldScript
548+
;(contextBridge as any).executeInMainWorld({
549+
func: mainWorldScript,
546550
})
547551
} catch (error) {
548552
console.error(`injectExtensionAPIs error (${location.href})`)

0 commit comments

Comments
 (0)