When a Second Life Marketplace url is clicked, load it using the preloaded marketplace floater

[Hecklezz]

PR with possible implementation: #5211

Currently if you click a Second Life marketplace link in the chat, it opens up the web_content floater which can take numerous seconds to load and then navigate to the page. Instead, I suggest using the marketplace floater instead which is preloaded (on systems with >8GB of RAM) which will allow it to immediately load and navigate to the marketplace page.

---

This repo is using Opire - what does it mean? 👇

💵 Everyone can add rewards for this issue commenting /reward 100 (replace 100 with the amount).
🕵️‍♂️ If someone starts working on this issue to earn the rewards, they can comment /try to let everyone know!
🙌 And when they open the PR, they can comment /claim #5210 either in the PR description or in a PR's comment.

🪙 Also, everyone can tip any user commenting /tip 20 @Hecklezz (replace 20 with the amount, and @Hecklezz with the user to tip).

📖 If you want to learn more, check out our documentation.

[Hecklezz]

I noticed a small bug that occurs if you enter a marketplace url into the viewers navigation bar (not to be confused with the web browsers navigation bar)

What happens if you try and navigate to a marketplace url using the navigation bar at the top of the viewer:

1. onOpen is called and navigates to the url with navigateTo which doesn't set the address bar url immediately
2. The onCommit callback from the viewers navigation bar fires which triggers onEnterAddress
3. Because the address bar url hasn't been updated yet after the call to navigateTo, it navigates to whatever the url that was last left in there
4. Results in it not navigating to the url you entered in the navigation bar (first goes to the url you want, then right back to the last one)

Here is a PR which should correct this-
#5264

[Dan-Linden]

Reopened. On Mac, clicking a marketplace link in chat opens a regular internal web browser, which is not logged in to my account.

Looks good on Windows 11.

Tested on Second Life Release 26.2.0.21655710006 on Win11/OSX in the scope of https://github.com/secondlife/iqa/issues/606

[Hecklezz]

Reopened. On Mac, clicking a marketplace link in chat opens a regular internal web browser, which is not logged in to my account.

Odd, the few Mac people I had test this in Firestorm had it behaving correctly, and we haven't had any Jira tickets about it not working since our latest release.
I'll ask them to test on Second Life Viewer 26.2.0 when they can and let me know the result.

Just making sure, the marketplace link you used to test started with https:// and not http://? Also your MarketplaceURL hasn't been modified from default? As the way I implemented it is based off what MarketplaceURL is set to.
Oh another thing, did the url end in just .com? If so, that could also be it (missing trailing /) and maybe it would be a good idea to trim off the / when checking the marketplace url just in case the marketplace url ends just in .com and that's it (since MarketplaceURL ends in /).

[Hecklezz]

Just had a friend on Mac test clicking a link in chat and they said it all works testing it various ways-

did a log on
then pressed shop
it worked
then i copied a random item into a chat with you
the close web viewer
and clicked on the link
and worked
ill try it from the link directy after a relog
worked
-Screenshot- (screenshot is below in the spoiler)

Screenshot showing it working

If you are able to retest with a link that starts with https, doesn't just end in .com without a /, and your MarketplaceURL is default, it would be great.
Otherwise if you'd like, I can put up a PR to make the marketplace url detection a bit more robust where it doesn't rely on https:// and the trailing slash of MarketplaceURL is ignored.

EDIT: The PR would look like this for the change in LLFloaterMarketplace::isMarketplaceURL if desired-

bool LLFloaterMarketplace::isMarketplaceURL(const std::string& url)
{
    auto trimURL = [](std::string_view url) -> std::string_view
    {
        if (url.starts_with("https://"))
            url.remove_prefix(8);
        else if (url.starts_with("http://"))
            url.remove_prefix(7);

        while (!url.empty() && url.back() == '/')
            url.remove_suffix(1);

        return url;
    };

    static LLCachedControl<std::string> marketplace_url(gSavedSettings, "MarketplaceURL", "https://marketplace.secondlife.com/");
    std::string_view marketplace_url_trimmed = trimURL(marketplace_url());
    std::string_view url_trimmed = trimURL(url);

    return !marketplace_url_trimmed.empty() && url_trimmed.starts_with(marketplace_url_trimmed);
}

Edit: I put up the PR here to implement the above change- #5459