From de872b26d773feba6c1e0790b07be9e12b2fe5fe Mon Sep 17 00:00:00 2001
From: Volker Lamp <vlamp@apache.org>
Date: Mon, 23 Feb 2026 20:31:33 +0100
Subject: [PATCH 1/2] Javadoc improvements. No functional changes.

---
 .../shiro/authz/RolesAuthorizationFilter.java      | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/tynamo/security/shiro/authz/RolesAuthorizationFilter.java b/src/main/java/org/tynamo/security/shiro/authz/RolesAuthorizationFilter.java
index 91ad83b..7ca0d7f 100644
--- a/src/main/java/org/tynamo/security/shiro/authz/RolesAuthorizationFilter.java
+++ b/src/main/java/org/tynamo/security/shiro/authz/RolesAuthorizationFilter.java
@@ -30,8 +30,9 @@
 
 
 /**
- * Filter that allows access if the current user has the roles specified by the mapped value, or denies access
- * if the user does not have all of the roles specified.
+ * Filter that allows access based on the roles specified by the mapped value.
+ * Access is granted if <em>no roles are specified</em> or the current user has <em>all</em> of roles.
+ * Access is denied if the current user has none of the roles.
  *
  * @since 0.4.0
  */
@@ -40,8 +41,13 @@ public RolesAuthorizationFilter(LoginContextService loginContextService) {
 		super(loginContextService);
 	}
 
-    //TODO - complete JavaDoc
-
+    /**
+     * {@inheritDoc}
+     * @param request {@inheritDoc}
+     * @param response {@inheritDoc}
+     * @param mappedValue a String array containing the roles all of which the current user must <em>all</em> have to be granted access
+     * @return {@inheritDoc}
+     */
     @SuppressWarnings({"unchecked"})
     public boolean isAccessAllowed(ServletRequest request, ServletResponse response, Object mappedValue) throws IOException {
 

From 8451bfb6a41ae1c2b5defaecd020ee71158dd364 Mon Sep 17 00:00:00 2001
From: Volker Lamp <vlamp@apache.org>
Date: Mon, 23 Feb 2026 21:40:02 +0100
Subject: [PATCH 2/2] Wording improved. Description corrected.

---
 .../security/shiro/authz/RolesAuthorizationFilter.java      | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/tynamo/security/shiro/authz/RolesAuthorizationFilter.java b/src/main/java/org/tynamo/security/shiro/authz/RolesAuthorizationFilter.java
index 7ca0d7f..4e6ed53 100644
--- a/src/main/java/org/tynamo/security/shiro/authz/RolesAuthorizationFilter.java
+++ b/src/main/java/org/tynamo/security/shiro/authz/RolesAuthorizationFilter.java
@@ -30,9 +30,9 @@
 
 
 /**
- * Filter that allows access based on the roles specified by the mapped value.
- * Access is granted if <em>no roles are specified</em> or the current user has <em>all</em> of roles.
- * Access is denied if the current user has none of the roles.
+ * Filter that allows access based on all of the roles specified by the mapped value.
+ * Access is granted if <em>no roles are specified</em> or if the current user has <em>all</em> of the roles.
+ * Access is denied if the current user does not have all of the roles.
  *
  * @since 0.4.0
  */