Skip to content

Commit ae60bea

Browse files
authored
feat: allow configurable deployment strategy (#163)
* feat: allow configurable deployment strategy * ci: pin ubuntu version in lint-test.yaml * ci: update python version in lint-test.yaml
1 parent 642a347 commit ae60bea

File tree

5 files changed

+11
-3
lines changed

5 files changed

+11
-3
lines changed

.github/workflows/lint-test.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ jobs:
2121
- name: Set up Python
2222
uses: actions/setup-python@v5
2323
with:
24-
python-version: 3.7
24+
python-version: '3.x'
25+
check-latest: true
2526

2627
- name: Set up chart-testing
2728
uses: helm/[email protected]

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ and their default values.
110110
| `priorityClass.name` | PriorityClassName to be specified in pod spec | `""` |
111111
| `replicaCount` | Desired number of pods | `1` |
112112
| `replicaCountEnabled` | Enable the replicaCount field | `true` |
113+
| `strategy` | The deployment strategy field | If persistence is enabled, the strategy type is set to `Recreate`, otherwise `RollingUpdate` |
113114
| `livenessProbe` | Configuration of liveness probe | `{}` |
114115
| `readinessProbe` | Configuration of readiness probe | `{}` |
115116
| `resources` | CPU/Memory resource requests/limits | `{}` |

charts/verdaccio/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apiVersion: v2
22
description: A lightweight private node.js proxy registry
33
name: verdaccio
4-
version: 4.25.1
4+
version: 4.26.0
55
appVersion: 6.0.4
66
home: https://verdaccio.org
77
icon: https://cdn.verdaccio.dev/logos/default.png

charts/verdaccio/templates/deployment.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,11 @@ spec:
1818
matchLabels:
1919
{{- include "verdaccio.selectorLabels" . | nindent 6 }}
2020
strategy:
21-
{{- if .Values.persistence.enabled }}
21+
{{- if .Values.strategy }}
22+
{{- with .Values.strategy }}
23+
{{- toYaml . | nindent 4}}
24+
{{- end }}
25+
{{- else if .Values.persistence.enabled }}
2226
type: Recreate
2327
rollingUpdate: null
2428
{{- else }}

charts/verdaccio/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ replicaCount: 1
5353

5454
revisionHistoryLimit: 10
5555

56+
strategy: {}
57+
5658
## Define Probes
5759
## ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#configure-probes
5860
livenessProbe: {}

0 commit comments

Comments
 (0)