Skip to content

RPC Unmarshaling Bug #48

@georgezgeorgez

Description

@georgezgeorgez

There are several rpc unmarshalling bugs.
The pattern seems to be trying to pre-allocate the slice but using its own length instead of the auxiliary data.
It seems like a copy and paste from the marshalling functions that were not replaced fully.

Example:

aux.Phases = make([]*Phase, len(p.Phases))
p.Phases = make([]*Phase, len(p.Phases))

I will first gather all the instances I can find and them make an MR if no one finds others.

p.Phases = make([]*Phase, len(p.Phases))

r.Fusions = make([]*FusionEntry, len(r.Fusions))

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions