mm-memcg-use-consistent-gfp-flags-during-readahead-checkpatch-fixes

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
torvalds#155: FILE: mm/readahead.c:111:
+		struct list_head *pages, unsigned nr_pages, gfp_t gfp_mask)

WARNING: line over 80 characters
torvalds#165: FILE: mm/readahead.c:129:
+		if (!add_to_page_cache_lru(page, mapping, page->index, gfp_mask)) {

WARNING: braces {} are not necessary for single statement blocks
torvalds#165: FILE: mm/readahead.c:129:
+		if (!add_to_page_cache_lru(page, mapping, page->index, gfp_mask)) {
 			mapping->a_ops->readpage(filp, page);
 		}

total: 0 errors, 3 warnings, 111 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/mm-memcg-use-consistent-gfp-flags-during-readahead.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Michal Hocko <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>

Author: akpm00

mm/readahead.c

@@ -108,7 +108,7 @@ int read_cache_pages(struct address_space *mapping, struct list_head *pages,
 EXPORT_SYMBOL(read_cache_pages);
 
 static int read_pages(struct address_space *mapping, struct file *filp,
-		struct list_head *pages, unsigned nr_pages, gfp_t gfp_mask)
+		struct list_head *pages, unsigned int nr_pages, gfp_t gfp)
 {
 	struct blk_plug plug;
 	unsigned page_idx;
@@ -126,9 +126,8 @@ static int read_pages(struct address_space *mapping, struct file *filp,
 	for (page_idx = 0; page_idx < nr_pages; page_idx++) {
 		struct page *page = lru_to_page(pages);
 		list_del(&page->lru);
-		if (!add_to_page_cache_lru(page, mapping, page->index, gfp_mask)) {
+		if (!add_to_page_cache_lru(page, mapping, page->index, gfp))
 			mapping->a_ops->readpage(filp, page);
-		}
 		put_page(page);
 	}
 	ret = 0;