Skip to content

Commit a0571a6

Browse files
authored
Import TextTestResult in test runner instead of _TextTestResult (cythonGH-4415)
All the versions we currently test are new enough that the alias is no longer necessary.
1 parent c129b15 commit a0571a6

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

Cython/Tests/xmlrunner.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def test_sample(self):
4343
import os
4444
import sys
4545
import time
46-
from unittest import TestResult, _TextTestResult, TextTestRunner
46+
from unittest import TestResult, TextTestResult, TextTestRunner
4747
import xml.dom.minidom
4848
try:
4949
from StringIO import StringIO
@@ -95,15 +95,15 @@ def get_error_info(self):
9595
self.err, self.test_method)
9696

9797

98-
class _XMLTestResult(_TextTestResult):
98+
class _XMLTestResult(TextTestResult):
9999
"""A test result class that can express test results in a XML report.
100100
101101
Used by XMLTestRunner.
102102
"""
103103
def __init__(self, stream=sys.stderr, descriptions=1, verbosity=1,
104104
elapsed_times=True):
105105
"Create a new instance of _XMLTestResult."
106-
_TextTestResult.__init__(self, stream, descriptions, verbosity)
106+
TextTestResult.__init__(self, stream, descriptions, verbosity)
107107
self.successes = []
108108
self.callback = None
109109
self.elapsed_times = elapsed_times
@@ -158,7 +158,7 @@ def startTest(self, test):
158158
def stopTest(self, test):
159159
"Called after execute each test method."
160160
self._restore_standard_output()
161-
_TextTestResult.stopTest(self, test)
161+
TextTestResult.stopTest(self, test)
162162
self.stop_time = time.time()
163163

164164
if self.callback and callable(self.callback):

runtests.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1626,14 +1626,11 @@ def __init__(self, **kwargs):
16261626
def shortDescription(self):
16271627
return self._shortDescription
16281628

1629-
try: # Py2.7+ and Py3.2+
1630-
from unittest.runner import _TextTestResult
1631-
except ImportError:
1632-
from unittest import _TextTestResult
1629+
from unittest import TextTestResult
16331630

1634-
class PartialTestResult(_TextTestResult):
1631+
class PartialTestResult(TextTestResult):
16351632
def __init__(self, base_result):
1636-
_TextTestResult.__init__(
1633+
TextTestResult.__init__(
16371634
self, self._StringIO(), True,
16381635
base_result.dots + base_result.showAll*2)
16391636

0 commit comments

Comments
 (0)