chore[internal]: rename and cleanup functions

Author: 0xjuanma

internal/app/commands.go

@@ -370,7 +370,7 @@ func fetchGoalLinks(redditClient *reddit.Client, details *api.MatchDetails) tea.
 		}
 
 		// Fetch links for all goals (uses cache internally)
-		links := redditClient.GetGoalLinks(goals)
+		links := redditClient.GoalLinks(goals)
 
 		return goalLinksMsg{matchID: details.ID, links: links}
 	}

internal/app/update.go

@@ -989,9 +989,9 @@ func (m model) handleGoalLinks(msg goalLinksMsg) (tea.Model, tea.Cmd) {
 	return m, nil
 }
 
-// GetGoalReplayURL returns the replay URL for a goal if available.
+// GoalReplayURL returns the replay URL for a goal if available.
 // Returns empty string if no replay link is cached.
-func (m *model) GetGoalReplayURL(matchID, minute int) string {
+func (m *model) GoalReplayURL(matchID, minute int) string {
 	if m.goalLinks == nil {
 		return ""
 	}

internal/data/settings.go

@@ -157,9 +157,9 @@ var DefaultLeagueIDs = []int{
 	42, // UEFA Champions League
 }
 
-// GetActiveLeagueIDs returns the league IDs that should be used for API calls.
+// ActiveLeagueIDs returns the league IDs that should be used for API calls.
 // If no leagues are selected in settings, returns the default leagues (not all).
-func GetActiveLeagueIDs() []int {
+func ActiveLeagueIDs() []int {
 	settings, err := LoadSettings()
 	if err != nil || len(settings.SelectedLeagues) == 0 {
 		// Return default leagues for efficient API usage
@@ -169,8 +169,8 @@ func GetActiveLeagueIDs() []int {
 	return settings.SelectedLeagues
 }
 
-// GetAllLeagueIDs returns all supported league IDs (used as fallback).
-func GetAllLeagueIDs() []int {
+// AllLeagueIDs returns all supported league IDs (used as fallback).
+func AllLeagueIDs() []int {
 	ids := make([]int, len(AllSupportedLeagues))
 	for i, league := range AllSupportedLeagues {
 		ids[i] = league.ID

internal/fotmob/cache.go

@@ -135,8 +135,8 @@ func (c *ResponseCache) CachedMatchIDs() []int {
 	return ids
 }
 
-// ClearDetailsCache clears all cached match details.
-func (c *ResponseCache) ClearDetailsCache() {
+// ClearDetails clears all cached match details.
+func (c *ResponseCache) ClearDetails() {
 	c.detailsMu.Lock()
 	defer c.detailsMu.Unlock()
 	c.detailsCache = make(map[int]cachedDetails)
@@ -172,9 +172,9 @@ func (c *ResponseCache) SetLiveMatches(matches []api.Match) {
 	}
 }
 
-// ClearLiveCache invalidates the live matches cache.
+// ClearLive invalidates the live matches cache.
 // Call this to force a refresh on next fetch.
-func (c *ResponseCache) ClearLiveCache() {
+func (c *ResponseCache) ClearLive() {
 	c.liveMu.Lock()
 	defer c.liveMu.Unlock()
 	c.liveCache = nil

internal/fotmob/client.go

@@ -16,16 +16,16 @@ const (
 	baseURL = "https://www.fotmob.com/api"
 )
 
-// GetActiveLeagues returns the league IDs to use for API calls.
+// ActiveLeagues returns the league IDs to use for API calls.
 // This respects user settings - if specific leagues are selected, only those are returned.
 // If no selection is made, returns all supported leagues.
-func GetActiveLeagues() []int {
-	return data.GetActiveLeagueIDs()
+func ActiveLeagues() []int {
+	return data.ActiveLeagueIDs()
 }
 
 // SupportedLeagues is kept for backward compatibility but now uses settings.
-// Use GetActiveLeagues() for dynamic league selection based on user preferences.
-var SupportedLeagues = data.GetAllLeagueIDs()
+// Use ActiveLeagues() for dynamic league selection based on user preferences.
+var SupportedLeagues = data.AllLeagueIDs()
 
 // Client implements the api.Client interface for FotMob API
 type Client struct {
@@ -119,7 +119,7 @@ func (c *Client) MatchesByDateWithTabs(ctx context.Context, date time.Time, tabs
 	var skippedFromCache int
 
 	// Get active leagues (respects user settings)
-	activeLeagues := GetActiveLeagues()
+	activeLeagues := ActiveLeagues()
 
 	// Query specified tabs
 	for _, tab := range tabs {

internal/fotmob/live.go

@@ -46,7 +46,7 @@ func (c *Client) LiveMatches(ctx context.Context) ([]api.Match, error) {
 // LiveMatchesForceRefresh fetches live matches, bypassing the cache.
 // Use this for periodic refreshes to get the latest data.
 func (c *Client) LiveMatchesForceRefresh(ctx context.Context) ([]api.Match, error) {
-	c.cache.ClearLiveCache()
+	c.cache.ClearLive()
 	return c.LiveMatches(ctx)
 }
 
@@ -79,12 +79,12 @@ func (c *Client) LiveMatchesForLeague(ctx context.Context, leagueID int) ([]api.
 
 // TotalLeagues returns the number of active leagues (respects user settings).
 func TotalLeagues() int {
-	return len(GetActiveLeagues())
+	return len(ActiveLeagues())
 }
 
 // LeagueIDAtIndex returns the league ID at the given index from active leagues.
 func LeagueIDAtIndex(index int) int {
-	activeLeagues := GetActiveLeagues()
+	activeLeagues := ActiveLeagues()
 	if index < 0 || index >= len(activeLeagues) {
 		return 0
 	}

internal/fotmob/stats.go

@@ -9,7 +9,7 @@ import (
 )
 
 // StatsData holds all matches data for the stats view.
-// This is returned by FetchStatsData and contains both finished and upcoming matches.
+// This is returned by StatsData and contains both finished and upcoming matches.
 type StatsData struct {
 	// AllFinished contains finished matches for all fetched days (5 days by default)
 	AllFinished []api.Match
@@ -23,7 +23,7 @@ type StatsData struct {
 // 5 days ensures we have data even during mid-week breaks.
 const StatsDataDays = 5
 
-// FetchStatsData fetches all stats data in one call: 5 days of finished matches + today's upcoming.
+// StatsData fetches all stats data in one call: 5 days of finished matches + today's upcoming.
 // This is the primary API for the stats view - always fetches 5 days, then filters client-side.
 //
 // OPTIMIZATION: Only queries "fixtures" tab for today (upcoming matches).
@@ -38,7 +38,7 @@ const StatsDataDays = 5
 // - Single fetch pattern (always 5 days)
 // - Covers mid-week breaks when no matches scheduled
 // - Instant switching between Today/5d views after initial load
-func (c *Client) FetchStatsData(ctx context.Context) (*StatsData, error) {
+func (c *Client) StatsData(ctx context.Context) (*StatsData, error) {
 	today := time.Now().UTC()
 	todayStr := today.Format("2006-01-02")
 

internal/reddit/cache.go

@@ -113,8 +113,8 @@ func (c *GoalLinkCache) Set(link GoalLink) error {
 	return c.saveLocked()
 }
 
-// GetAll returns all cached goal links for a match.
-func (c *GoalLinkCache) GetAll(matchID int) []GoalLink {
+// All returns all cached goal links for a match.
+func (c *GoalLinkCache) All(matchID int) []GoalLink {
 	c.mu.RLock()
 	defer c.mu.RUnlock()
 

internal/reddit/client.go

@@ -148,9 +148,9 @@ func NewClientWithFetcher(fetcher Fetcher, cache *GoalLinkCache) *Client {
 	}
 }
 
-// GetGoalLink retrieves a cached goal link or fetches from Reddit if not cached.
+// GoalLink retrieves a cached goal link or fetches from Reddit if not cached.
 // Returns nil if the goal link was previously searched but not found.
-func (c *Client) GetGoalLink(goal GoalInfo) (*GoalLink, error) {
+func (c *Client) GoalLink(goal GoalInfo) (*GoalLink, error) {
 	key := GoalLinkKey{MatchID: goal.MatchID, Minute: goal.Minute}
 
 	// Check cache first (includes "not found" markers)
@@ -186,9 +186,9 @@ const BatchSize = 5
 // BatchDelay is the delay between batches to avoid rate limiting.
 const BatchDelay = 2 * time.Second
 
-// GetGoalLinks retrieves links for multiple goals, using cache where available.
+// GoalLinks retrieves links for multiple goals, using cache where available.
 // Goals are de-duplicated and batched to avoid rate limiting.
-func (c *Client) GetGoalLinks(goals []GoalInfo) map[GoalLinkKey]*GoalLink {
+func (c *Client) GoalLinks(goals []GoalInfo) map[GoalLinkKey]*GoalLink {
 	results := make(map[GoalLinkKey]*GoalLink)
 
 	// De-duplicate goals by key and filter out already-cached goals
@@ -231,7 +231,7 @@ func (c *Client) GetGoalLinks(goals []GoalInfo) map[GoalLinkKey]*GoalLink {
 
 		for _, goal := range uncachedGoals[i:end] {
 			key := GoalLinkKey{MatchID: goal.MatchID, Minute: goal.Minute}
-			link, err := c.GetGoalLink(goal)
+			link, err := c.GoalLink(goal)
 			if err == nil && link != nil {
 				results[key] = link
 			}
@@ -261,14 +261,14 @@ func (c *Client) searchForGoal(goal GoalInfo) (*GoalLink, error) {
 			}, nil
 		}
 	}
-	
+
 	// Strategy 1 didn't find a match, try broader searches
 	// Only try one additional strategy to balance coverage vs rate limiting
 	var allResults []SearchResult
 	if err == nil {
 		allResults = append(allResults, results1...)
 	}
-	
+
 	// Strategy 2: Try with just the scoring team + minute
 	// Determine which team scored
 	scoringTeam := goal.AwayTeam
@@ -280,7 +280,7 @@ func (c *Client) searchForGoal(goal GoalInfo) (*GoalLink, error) {
 	if err == nil {
 		allResults = append(allResults, results2...)
 	}
-	
+
 	// Remove duplicates based on URL
 	seen := make(map[string]bool)
 	uniqueResults := make([]SearchResult, 0, len(allResults))

scripts/test_fotmob_stats.go

@@ -25,7 +25,7 @@ func main() {
 	defer cancel()
 
 	startTime := time.Now()
-	statsData, err := client.FetchStatsData(ctx)
+	statsData, err := client.StatsData(ctx)
 	elapsed := time.Since(startTime)
 
 	if err != nil {