Skip to content

Commit 2b66d94

Browse files
authored
Merge pull request #70 from Point72/tkp/embed
Clean up comments
2 parents 5ca1484 + 158a136 commit 2b66d94

4 files changed

Lines changed: 0 additions & 38 deletions

File tree

chatom/base/message.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -600,9 +600,7 @@ def forwarded_from_id(self) -> str:
600600
"""
601601
return self.forwarded_from.id if self.forwarded_from else ""
602602

603-
# -------------------------------------------------------------------------
604603
# Response Convenience Methods
605-
# -------------------------------------------------------------------------
606604
# These methods construct new Message instances based on this message.
607605
# They make it easy to create replies, forwards, or quotes.
608606

chatom/format/embed.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,13 @@ class FormattedEmbed(BaseModel):
3838

3939
embed: Embed = Field(default_factory=Embed, description="The underlying embed data.")
4040

41-
# ------------------------------------------------------------------
4241
# Convenience constructors
43-
# ------------------------------------------------------------------
4442
@classmethod
4543
def from_embed(cls, embed: Embed) -> "FormattedEmbed":
4644
"""Create a FormattedEmbed from an existing Embed instance."""
4745
return cls(embed=embed)
4846

49-
# ------------------------------------------------------------------
5047
# Text fallback rendering (for content list)
51-
# ------------------------------------------------------------------
5248
def render(self, format: FORMAT = Format.MARKDOWN) -> str:
5349
"""Render the embed as a text fallback.
5450
@@ -150,9 +146,7 @@ def _render_footer(self, fmt: Format) -> str:
150146
return f"_{footer.text}_"
151147
return footer.text
152148

153-
# ------------------------------------------------------------------
154149
# Structured per-backend payloads
155-
# ------------------------------------------------------------------
156150
def to_discord_dict(self) -> Dict[str, Any]:
157151
"""Convert to a Discord embed dict suitable for the API."""
158152
e = self.embed

chatom/tests/test_format.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2482,11 +2482,6 @@ def test_action_row_with_select_symphony(self):
24822482
assert "<select" in result["messageml"]
24832483

24842484

2485-
# -------------------------------------------------------------------------
2486-
# Phase 1: Embed / FormattedEmbed tests
2487-
# -------------------------------------------------------------------------
2488-
2489-
24902485
class TestFormattedEmbed:
24912486
"""Tests for the FormattedEmbed content node."""
24922487

@@ -2507,8 +2502,6 @@ def _make_embed(self):
25072502
],
25082503
)
25092504

2510-
# -- text fallback rendering --
2511-
25122505
def test_render_markdown(self):
25132506
fe = FormattedEmbed(embed=self._make_embed())
25142507
rendered = fe.render(Format.MARKDOWN)
@@ -2539,8 +2532,6 @@ def test_render_plaintext(self):
25392532
rendered = fe.render(Format.PLAINTEXT)
25402533
assert "Uptime: 3d 12h" in rendered
25412534

2542-
# -- structured payloads --
2543-
25442535
def test_to_discord_dict(self):
25452536
fe = FormattedEmbed(embed=self._make_embed())
25462537
d = fe.to_discord_dict()
@@ -2581,8 +2572,6 @@ def test_to_telegram_html(self):
25812572
assert "<b>" in html
25822573
assert "Bot Status" in html
25832574

2584-
# -- from_embed factory --
2585-
25862575
def test_from_embed(self):
25872576
from chatom.base.embed import Embed
25882577

chatom/tests/test_mcp.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@
1616
)
1717
from chatom.mcp import build_mcp_server
1818

19-
# ---------------------------------------------------------------------------
20-
# Minimal mock backend (same pattern as chatom/tests/test_agent.py)
21-
# ---------------------------------------------------------------------------
22-
2319

2420
class _MockBackend:
2521
"""Bare-bones BackendBase stand-in for MCP server tests."""
@@ -133,11 +129,6 @@ async def add_reaction(
133129
self.reactions.append({"message_id": msg_id, "emoji": emoji, "channel": ch_id})
134130

135131

136-
# ---------------------------------------------------------------------------
137-
# Fixtures
138-
# ---------------------------------------------------------------------------
139-
140-
141132
@pytest.fixture
142133
def alice() -> User:
143134
return User(id="U1", name="Alice", display_name="Alice A")
@@ -177,11 +168,6 @@ def mock_backend(alice: User, general: Channel, sample_messages: List[Message])
177168
)
178169

179170

180-
# ---------------------------------------------------------------------------
181-
# Server builder tests
182-
# ---------------------------------------------------------------------------
183-
184-
185171
class TestBuildMcpServer:
186172
"""Tests for build_mcp_server via the Client (avoids accessing internals)."""
187173

@@ -230,11 +216,6 @@ async def test_capability_gating(self) -> None:
230216
assert "read_channel_history" in tool_names
231217

232218

233-
# ---------------------------------------------------------------------------
234-
# MCP Client integration tests
235-
# ---------------------------------------------------------------------------
236-
237-
238219
class TestMcpClientIntegration:
239220
"""Test tools via FastMCP Client (in-process, no subprocess)."""
240221

0 commit comments

Comments
 (0)