Fix lint JS

Author: rldhont

.pre-commit-config.yaml

@@ -22,13 +22,13 @@ repos:
         args: [--fix]
 
   - repo: https://github.com/pre-commit/mirrors-eslint
-    rev: v9.30.1
+    rev: v10.0.1
     hooks:
       - id: eslint
         files: \.[jt]sx?$  # *.js, *.jsx, *.ts and *.tsx
         types: [ file ]
         additional_dependencies:
-          - eslint@9.30.1
+          - eslint@10.0.1
 
   - repo: local
     hooks:

assets/src/components/DxfExport.js

@@ -57,7 +57,7 @@ export default class DxfExport extends HTMLElement {
     /**
      * Generates the HTML template for the DXF export component
      * @private
-     * @returns {Object} The lit-html template
+     * @returns {object} The lit-html template
      */
     _template() {
         const exportableLayers = this._getExportableLayers();
@@ -90,6 +90,8 @@ export default class DxfExport extends HTMLElement {
 
     /**
      * Renders the scale selector
+     * @param currentScale
+     * @param availableScales
      * @private
      */
     _renderScaleSelector(currentScale, availableScales) {
@@ -169,6 +171,7 @@ export default class DxfExport extends HTMLElement {
 
     /**
      * Renders the layers list
+     * @param exportableLayers
      * @private
      */
     _renderLayersList(exportableLayers) {
@@ -198,6 +201,7 @@ export default class DxfExport extends HTMLElement {
 
     /**
      * Handles scale selection change
+     * @param event
      * @private
      */
     _handleScaleChange(event) {
@@ -320,7 +324,7 @@ export default class DxfExport extends HTMLElement {
      * Shows an error message
      * @private
      * @param {string} message - Error message
-     * @param {Error|Object} [error] - Optional error object
+     * @param {Error | object} [error] - Optional error object
      */
     _showError(message, error = null) {
         let displayMessage = message || lizDict['dxfexport.error'] || 'Error during DXF export';
@@ -371,7 +375,7 @@ export default class DxfExport extends HTMLElement {
     /**
      * Collects layer information for export
      * @private
-     * @returns {Object} Object containing layers, styles, opacities, and tokens
+     * @returns {object} Object containing layers, styles, opacities, and tokens
      */
     _collectLayerInformation() {
         const result = {
@@ -429,7 +433,7 @@ export default class DxfExport extends HTMLElement {
     /**
      * Builds WMS GetMap parameters for DXF export
      * @private
-     * @returns {Object} WMS parameters object
+     * @returns {object} WMS parameters object
      */
     _buildWmsParameters() {
         // Get map extent and projection
@@ -494,7 +498,7 @@ export default class DxfExport extends HTMLElement {
      * Downloads a DXF file via XHR
      * @private
      * @param {string} url - Service URL
-     * @param {Object} parameters - WMS parameters
+     * @param {object} parameters - WMS parameters
      * @param {string} filename - Output filename
      */
     _downloadDxfFile(url, parameters, filename) {

assets/src/components/Treeview.js

@@ -311,7 +311,7 @@ export default class Treeview extends HTMLElement {
     }
 
     _createGetMediaLink(path) {
-        let url = '';
+        let url;
         // Test if the path is internal
         if (MEDIA_REGEX.test(path)) {
             const mediaLink = globalThis['lizUrls'].media + '?' + new URLSearchParams(globalThis['lizUrls'].params);

assets/src/dependencies/mgrs.js

@@ -484,7 +484,7 @@ function decode(mgrsString) {
 
     const { length } = mgrsString;
 
-    let hunK = null;
+    let hunK;
     let sb = '';
     let testChar;
     let i = 0;

assets/src/index.js

@@ -107,21 +107,21 @@ const definedCustomElements = () => {
     window.customElements.define('lizmap-typeahead', TypeAHead);
 
     /**
-    * At this point the user interface is fully loaded.
-    * External javascripts can subscribe to this event to perform post load
-    * operations or cutomizations
-    *
-    * Example in my_custom_script.js
-    *
-    * lizMap.subscribe(() => {
-    *          // pseudo-code
-    *          intercatWithPrintPanel();
-    *          interactWithSelectionPanel();
-    *          inteactWithLocateByLayerPanel();
-    *     },
-    *     'lizmap.uicreated'
-    * );
-    */
+     * At this point the user interface is fully loaded.
+     * External javascripts can subscribe to this event to perform post load
+     * operations or cutomizations
+     *
+     * Example in my_custom_script.js
+     *
+     * lizMap.subscribe(() => {
+     *          // pseudo-code
+     *          intercatWithPrintPanel();
+     *          interactWithSelectionPanel();
+     *          inteactWithLocateByLayerPanel();
+     *     },
+     *     'lizmap.uicreated'
+     * );
+     */
     lizMap.mainEventDispatcher.dispatch('lizmap.uicreated');
 }
 

assets/src/modules/Digitizing.js

@@ -1710,7 +1710,6 @@ export class Digitizing {
         }
         const color = this.featureDrawn[index].get('color') || this._drawColor;
         let opacityFactor = this.featureDrawn[index].get('mode') == 'textonly' ? 0 : 1;
-        let symbolizer = '';
         let strokeAndFill =
         `<Stroke>
             <SvgParameter name="stroke">${color}</SvgParameter>
@@ -1723,6 +1722,7 @@ export class Digitizing {
         </Fill>`;
 
         // We consider LINESTRING and POLYGON together currently
+        let symbolizer;
         if (this.featureDrawn[index].getGeometry().getType() === 'Point') {
             symbolizer =
             `<PointSymbolizer>

assets/src/modules/Lizmap.js

@@ -87,10 +87,10 @@ export default class Lizmap {
             // child which could be a layer or a group.
             let wmsLayer = wmsCapabilities.Capability.Layer;
             while (wmsLayer.BoundingBox === undefined) {
-            // breaking while before the loop because wmsLayer.Layer is not iterable
+                // breaking while before the loop because wmsLayer.Layer is not iterable
                 if (wmsLayer.Layer === undefined) {
-                        break;
-                    }
+                    break;
+                }
                 for (const wmsChildLayer of wmsLayer.Layer) {
                     if (Array.isArray(wmsChildLayer.BoundingBox)) {
                         wmsLayer = wmsChildLayer;

assets/src/modules/Permalink.js

@@ -276,7 +276,7 @@ export default class Permalink {
             return;
         }
 
-        let hash = '';
+        let hash;
 
         // BBOX
         let bbox = mainLizmap.extent;

assets/src/modules/Search.js

@@ -322,7 +322,7 @@ export default class Search {
         var searchAdded = false;
         for (var i = 0, len = searchOptions.length; i < len; i++) {
             var searchOption = searchOptions[i];
-            var searchAddedResult = false;
+            var searchAddedResult;
             if (searchOption.type == 'externalSearch') {
                 searchAddedResult = this._addExternalSearch(searchOption);
             }

assets/src/modules/state/BaseLayer.js

@@ -530,7 +530,7 @@ export class BaseLayersState extends EventDispatcher {
             if (blConfig.hasLayerConfig) {
                 itemState = lgCollection.findLayerOrGroupByName(blConfig.name);
             }
-            let baseLayer = null;
+            let baseLayer;
             switch(blConfig.type) {
                 case BaseLayerTypes.Empty:
                     baseLayer = new EmptyBaseLayerState(blConfig, itemState);