Improve response code when certificate not found during ContentHostingConfiguration provisioning. Issue found during uplift testing.

davidjwbbc · davidjwbbc · commit fd81e98d509b · 2025-01-29T10:39:04.000Z
diff --git a/src/5gmsaf/msaf-m1-sm.c b/src/5gmsaf/msaf-m1-sm.c
@@ -376,7 +376,7 @@ void msaf_m1_state_functional(ogs_fsm_t *s, msaf_event_t *e)
                                             char *err;
                                             err = ogs_msprintf("Unable to retrieve certificate for the Provisioning Session [%s].", message->h.resource.component[1]);
                                             ogs_error("%s", err);
-                                            ogs_assert(true == nf_server_send_error(stream, 500, 2, message, "Internal Server Error.", err, NULL, NULL, m1_contenthostingprovisioning_api, app_meta));
+                                            ogs_assert(true == nf_server_send_error(stream, 404, 2, message, "Certificate not found.", err, NULL, NULL, m1_contenthostingprovisioning_api, app_meta));
                                             ogs_free(err);
                                         }
                                     } else {

Original file line number	Diff line number	Diff line change
`@@ -376,7 +376,7 @@ void msaf_m1_state_functional(ogs_fsm_t s, msaf_event_t e)`
`376`	`376`	`char *err;`
`377`	`377`	`err = ogs_msprintf("Unable to retrieve certificate for the Provisioning Session [%s].", message->h.resource.component[1]);`
`378`	`378`	`ogs_error("%s", err);`
`379`		`- ogs_assert(true == nf_server_send_error(stream, 500, 2, message, "Internal Server Error.", err, NULL, NULL, m1_contenthostingprovisioning_api, app_meta));`
	`379`	`+ ogs_assert(true == nf_server_send_error(stream, 404, 2, message, "Certificate not found.", err, NULL, NULL, m1_contenthostingprovisioning_api, app_meta));`
`380`	`380`	`ogs_free(err);`
`381`	`381`	`}`
`382`	`382`	`} else {`