fix: address review round 3 (3 medium, 1 low)

- migrate-memories.mjs: pass apiKey for LanceDB Cloud URIs (medium #1)
- Throw on old schema without scope column instead of silent warn (medium #2)
- Log hint when rerank API key is present but RERANK_PROVIDER unset (medium qwibitai#3)
- Validate vectorDim early for custom providers (low qwibitai#4)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: 5queezer

container/agent-runner/src/memory-store.ts

@@ -204,16 +204,20 @@ export class MemoryStore {
     try {
       table = await db.openTable(TABLE_NAME);
 
-      // Check if we need to add scope column for backward compatibility
+      // Check if existing data has scope column (backward compatibility)
       try {
         const sample = await table.query().limit(1).toArray();
         if (sample.length > 0 && !("scope" in sample[0])) {
-          console.warn(
-            "Adding scope column for backward compatibility with existing data",
+          throw new Error(
+            `Existing LanceDB table at "${this.config.dbPath}" uses old schema without "scope" column.\n` +
+            `  Fix: Re-embed your memories using: node scripts/migrate-memories.mjs <backup.jsonl> "${this.config.dbPath}"\n` +
+            `       Or delete the table directory and let it be recreated on first store.`,
           );
         }
-      } catch (err) {
-        console.warn("Could not check table schema:", err);
+      } catch (err: any) {
+        // Re-throw schema migration errors, only swallow probe failures
+        if (err?.message?.includes('old schema')) throw err;
+        console.warn("Could not check table schema:", err instanceof Error ? err.message : String(err));
       }
     } catch (_openErr) {
       // Table doesn't exist yet — create it

container/agent-runner/src/memory.ts

@@ -147,6 +147,19 @@ const RERANK_DEFAULTS: Record<string, RerankDefaults> = {
 function resolveRetrievalConfig(): Partial<RetrievalConfig> {
   const provider = RERANK_PROVIDER.toLowerCase();
   if (!provider || provider === 'none') {
+    // Hint: if a rerank-capable API key is present but RERANK_PROVIDER is unset
+    const hintKeys: Array<[string, string]> = [
+      ['JINA_API_KEY', 'jina'],
+      ['VOYAGE_API_KEY', 'voyage'],
+      ['PINECONE_API_KEY', 'pinecone'],
+      ['SILICONFLOW_API_KEY', 'siliconflow'],
+    ];
+    for (const [envKey, providerName] of hintKeys) {
+      if (process.env[envKey]) {
+        console.log(`[memory] Hint: ${envKey} is set but RERANK_PROVIDER is not — set RERANK_PROVIDER=${providerName} to enable cross-encoder reranking`);
+        break;
+      }
+    }
     return { rerank: 'none' };
   }
 
@@ -182,9 +195,15 @@ let _retriever: MemoryRetriever | null = null;
 function getStore(): MemoryStore {
   const embeddingConfig = resolveEmbeddingConfig();
   if (!_store) {
+    const vectorDim = embeddingConfig.dimensions || 0;
+    if (!vectorDim) {
+      throw new Error(
+        `Cannot determine embedding dimensions. Set EMBEDDING_DIM when using a custom provider.`,
+      );
+    }
     _store = new MemoryStore({
       dbPath:    LANCEDB_URI || LOCAL_DB_DIR,
-      vectorDim: embeddingConfig.dimensions || 0,
+      vectorDim,
       apiKey:    LANCEDB_URI ? (LANCEDB_API_KEY || undefined) : undefined,
     });
   }

scripts/migrate-memories.mjs

@@ -71,7 +71,10 @@ async function main() {
   console.log(`Embedding model: ${EMBEDDING_MODEL}`);
   console.log(`Embedding endpoint: ${BASE_URL}`);
 
-  const db = await lancedb.connect(lancedbDir);
+  const connectOpts = lancedbDir.startsWith('db://') && process.env.LANCEDB_API_KEY
+    ? { apiKey: process.env.LANCEDB_API_KEY }
+    : undefined;
+  const db = await lancedb.connect(lancedbDir, connectOpts);
 
   // Stream lines to avoid loading entire file into memory
   const rl = createInterface({