Skip to content

Commit 5ee15e3

Browse files
Copilot7474
andcommitted
fix: keep empty string result in file dialog placeholder functions
Co-authored-by: 7474 <4744735+7474@users.noreply.github.com>
1 parent 2329b8b commit 5ee15e3

File tree

2 files changed

+45
-3
lines changed

2 files changed

+45
-3
lines changed

SRC.Sharp/SRCCore/Expressions/Functions/File.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,6 @@ protected override ValueType InvokeInternal(SRC SRC, ValueType etype, string[] @
147147

148148
if (etype == ValueType.StringType)
149149
{
150-
str_result = GeneralLib.FormatNum(num_result);
151150
return ValueType.StringType;
152151
}
153152
else
@@ -230,7 +229,6 @@ protected override ValueType InvokeInternal(SRC SRC, ValueType etype, string[] @
230229

231230
if (etype == ValueType.StringType)
232231
{
233-
str_result = GeneralLib.FormatNum(num_result);
234232
return ValueType.StringType;
235233
}
236234
else
@@ -239,4 +237,4 @@ protected override ValueType InvokeInternal(SRC SRC, ValueType etype, string[] @
239237
}
240238
}
241239
}
242-
}
240+
}
Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
using Microsoft.VisualStudio.TestTools.UnitTesting;
2+
using SRCCore.Expressions.Functions;
3+
using SRCCore.TestLib;
4+
5+
namespace SRCCore.Expressions.Tests
6+
{
7+
[TestClass]
8+
public class FileFunctionTests
9+
{
10+
private static SRC CreateSrc()
11+
{
12+
return new SRC
13+
{
14+
GUI = new MockGUI(),
15+
};
16+
}
17+
18+
[TestMethod]
19+
public void Loadfiledialog_StringType_DefaultResultIsEmptyString()
20+
{
21+
var src = CreateSrc();
22+
var sut = new Loadfiledialog();
23+
24+
var resultType = sut.Invoke(src, ValueType.StringType, new string[1], 0, new bool[1], out var strResult, out var numResult);
25+
26+
Assert.AreEqual(ValueType.StringType, resultType);
27+
Assert.AreEqual("", strResult);
28+
Assert.AreEqual(0d, numResult);
29+
}
30+
31+
[TestMethod]
32+
public void Savefiledialog_StringType_DefaultResultIsEmptyString()
33+
{
34+
var src = CreateSrc();
35+
var sut = new Savefiledialog();
36+
37+
var resultType = sut.Invoke(src, ValueType.StringType, new string[1], 0, new bool[1], out var strResult, out var numResult);
38+
39+
Assert.AreEqual(ValueType.StringType, resultType);
40+
Assert.AreEqual("", strResult);
41+
Assert.AreEqual(0d, numResult);
42+
}
43+
}
44+
}

0 commit comments

Comments
 (0)