Feat/customize makers #367
Conversation
…/customize_makers # Conflicts: # app/src/main/java/com/adevinta/mappicker/MainActivity.kt
|
@chihung93 sorry for the late review. First of all, I would like to thank you for your contribution. It's very welcome! In order to properly review your PR please could add a screenshot with the final result? Also, please revert the Readme changes because it's difficult to read it if you change all the file with no needed modifications. Many thanks! |
|
Hi @ferranpons , thanks for your response, My google account console is expired now, Im trying to find some key to take a screenshot it. |
telegram-cloud-document-5-6325671410286986942.mp4Hi @ferranpons , I record a video for this PR |
ferranpons
left a comment
ferranpons
left a comment
There was a problem hiding this comment.
Many thanks for your contribution. Please make the changes suggested and we'll merge the PR.
|
@chihung93 You need to correct these Ktlint issues to be able to merge:
|
Fixed! Thanks. |
Merging owner master to my master
# Conflicts: # README.md
|
@chihung93 The build is still not passing. Please review the lint issues:
Checkout the build result here: https://github.com/AdevintaSpain/Leku/actions/runs/4126569199/jobs/7129972752 |
|
I have run ./gradlew :leku:ktlintMainSourceSetCheck . I believe that its good to go live.
|
|
@chihung93 Many thanks for your contribution! |
2 participants
I have added a customize makers for Current location and other location