When no location in the bundle, we are still doing a search #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch and showing results
ferranpons
approved these changes
Jan 10, 2024
Member
ferranpons
left a comment
ferranpons
left a comment
There was a problem hiding this comment.
👍 LGTM
Many thanks for your contribution!
delete-merged-branch
bot
deleted the
SCMI-112253-no-coordinates-in-bundle-show-results
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
When we are initializing Leku without coordinates (example: we haven't given location access beforehand), we are performing a search and displaying results. This ends up blocking the buttons in the screen.
Description
Set a default location, so we are not going to trigger the location search. Then, when user has given location access, everything's still going to work as expected.
Screenshots
Before:
https://github.com/AdevintaSpain/Leku/assets/6688705/f070f77c-6415-48e3-9fc7-35da3aed07aa
After:
https://github.com/AdevintaSpain/Leku/assets/6688705/f5972769-cc96-4728-b99b-097556cd73a5
Mandatory GIF