Scmi 112253 no coordinates in bundle show results #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 9, 2024 14:14
…ch and showing results
ferranpons
requested changes
Jan 10, 2024
| currentLocation?.longitude = 0.0 | ||
| setCurrentPositionLocation() | ||
| isLocationInformedFromBundle = true | ||
| if (ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED) { |
Member
There was a problem hiding this comment.
I prefer you to use "PermissionUtils" class instead of calling for permissions directly. Example:
if (PermissionUtils.isLocationPermissionGranted(applicationContext)) {
Collaborator
Author
There was a problem hiding this comment.
Thanks for the clarification! :D
ferranpons
approved these changes
Jan 10, 2024
delete-merged-branch
bot
deleted the
SCMI-112253-no-coordinates-in-bundle-show-results
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
I missed a really important point in my last PR. This default location is only needed when permissions aren't granted. Else, it's not necessary because we are going to retrieve the location we are at.