v6 - Sessions example #2232
v6 - Sessions example #2232
Conversation
OscarSpruit
added
the
Chore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @OscarSpruit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request adds a new example to the application, showcasing the integration of 'v6' components with session-based payment flows. It involves creating dedicated UI components and view models for this new example, and seamlessly integrating them into the existing application's navigation. Additionally, the changes reflect an ongoing refactoring of the session model within the PaymentsRepository, with existing session integrations being updated to use a legacy session creation method, while the new v6 example leverages the updated session handling.
Highlights
- New Example Integration: Introduced a new 'V6 Sessions' example to the application, demonstrating how to integrate
v6components with session management. This includes a newV6SessionsActivityandV6SessionsViewModel. - Session Model Transition: Initiated a transition in session handling by introducing a new
SessionModeland updating thePaymentsRepository. Existing session examples now utilize acreateSessionOldmethod, while the new V6 Sessions example uses the updatedcreateSessionmethod, which maps to the newSessionModel. - UI and Navigation Updates: Integrated the new 'V6 Sessions' example into the app's main menu and navigation flow, making it accessible via a new
ComponentItem.Entry.V6Sessionsand correspondingMainNavigation.V6Sessionsroute.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new example for v6 components using sessions, including a new V6SessionsActivity and V6SessionsViewModel. The existing session creation logic has been refactored, moving the old implementation to a new createSessionOld method and updating existing session-based examples to use it.
The review identified areas for improvement related to code duplication, UI clarity, and correctness.
example-app/src/main/java/com/adyen/checkout/example/ui/v6/V6SessionsViewModel.kt
Show resolved
Hide resolved
example-app/src/main/java/com/adyen/checkout/example/repositories/PaymentsRepository.kt
Show resolved
Hide resolved
example-app/src/main/java/com/adyen/checkout/example/ui/main/ComponentItem.kt
Show resolved
Hide resolved
✅ No public API changes |
|
Description
Create example integration for v6 components with sessions