Skip to content

Commit dfccb31

Browse files
committed
fix(client): fix issues raised through lgtm alerts
1 parent ef06240 commit dfccb31

File tree

9 files changed

+17
-17
lines changed

9 files changed

+17
-17
lines changed

client/components/build/RightSidebar/sections/Theme.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Theme } from '@reactive-resume/schema';
1+
import { Theme as ThemeType } from '@reactive-resume/schema';
22
import get from 'lodash/get';
33
import { useTranslation } from 'next-i18next';
44

@@ -16,7 +16,7 @@ const Theme = () => {
1616

1717
const dispatch = useAppDispatch();
1818

19-
const { background, text, primary } = useAppSelector<Theme>((state) => get(state.resume, 'metadata.theme'));
19+
const { background, text, primary } = useAppSelector<ThemeType>((state) => get(state.resume, 'metadata.theme'));
2020

2121
const handleChange = (property: string, color: string) => {
2222
dispatch(setResumeState({ path: `metadata.theme.${property}`, value: color }));

client/components/landing/Testimony.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { Testimony } from '@/data/testimonials';
1+
import { Testimony as TestimonyType } from '@/data/testimonials';
22

33
import styles from './Testimony.module.scss';
44

5-
type Props = Testimony;
5+
type Props = TestimonyType;
66

77
const Testimony: React.FC<Props> = ({ name, message }) => {
88
return (

client/constants/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ export const FONTS_QUERY = 'fonts';
33
export const RESUMES_QUERY = 'resumes';
44

55
// Regular Expressions
6-
export const VALID_URL_REGEX = /[-a-zA-Z0-9@:%._+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_+.~#?&//=]*)/;
6+
export const VALID_URL_REGEX = /[-a-zA-Z0-9@:%._+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_+.~#?&/=]*)/;
77

88
// Date Formats
99
export const FILENAME_TIMESTAMP = 'DDMMYYYYHHmmss';

client/templates/Castform/widgets/Section.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Email, Link, Phone } from '@mui/icons-material';
2-
import { ListItem, Section } from '@reactive-resume/schema';
2+
import { ListItem, Section as SectionType } from '@reactive-resume/schema';
33
import get from 'lodash/get';
44
import isArray from 'lodash/isArray';
55
import isEmpty from 'lodash/isEmpty';
@@ -20,7 +20,7 @@ const Section: React.FC<SectionProps> = ({
2020
headlinePath = 'headline',
2121
keywordsPath = 'keywords',
2222
}) => {
23-
const section: Section = useAppSelector((state) => get(state.resume, path, {}));
23+
const section: SectionType = useAppSelector((state) => get(state.resume, path, {}));
2424
const dateFormat: string = useAppSelector((state) => get(state.resume, 'metadata.date.format'));
2525

2626
if (!section.visible) return null;

client/templates/Gengar/widgets/Section.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Email, Link, Phone } from '@mui/icons-material';
2-
import { ListItem, Section } from '@reactive-resume/schema';
2+
import { ListItem, Section as SectionType } from '@reactive-resume/schema';
33
import get from 'lodash/get';
44
import isArray from 'lodash/isArray';
55
import isEmpty from 'lodash/isEmpty';
@@ -20,7 +20,7 @@ const Section: React.FC<SectionProps> = ({
2020
headlinePath = 'headline',
2121
keywordsPath = 'keywords',
2222
}) => {
23-
const section: Section = useAppSelector((state) => get(state.resume, path, {}));
23+
const section: SectionType = useAppSelector((state) => get(state.resume, path, {}));
2424
const dateFormat: string = useAppSelector((state) => get(state.resume, 'metadata.date.format'));
2525
const primaryColor: string = useAppSelector((state) => get(state.resume, 'metadata.theme.primary'));
2626

client/templates/Glalie/widgets/Section.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Email, Link, Phone } from '@mui/icons-material';
2-
import { ListItem, Section } from '@reactive-resume/schema';
2+
import { ListItem, Section as SectionType } from '@reactive-resume/schema';
33
import get from 'lodash/get';
44
import isArray from 'lodash/isArray';
55
import isEmpty from 'lodash/isEmpty';
@@ -21,7 +21,7 @@ const Section: React.FC<SectionProps> = ({
2121
headlinePath = 'headline',
2222
keywordsPath = 'keywords',
2323
}) => {
24-
const section: Section = useAppSelector((state) => get(state.resume, path, {}));
24+
const section: SectionType = useAppSelector((state) => get(state.resume, path, {}));
2525
const dateFormat: string = useAppSelector((state) => get(state.resume, 'metadata.date.format'));
2626
const primaryColor: string = useAppSelector((state) => get(state.resume, 'metadata.theme.primary'));
2727

client/templates/Kakuna/widgets/Section.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Email, Phone } from '@mui/icons-material';
2-
import { ListItem, Section } from '@reactive-resume/schema';
2+
import { ListItem, Section as SectionType } from '@reactive-resume/schema';
33
import get from 'lodash/get';
44
import isArray from 'lodash/isArray';
55
import isEmpty from 'lodash/isEmpty';
@@ -20,7 +20,7 @@ const Section: React.FC<SectionProps> = ({
2020
headlinePath = 'headline',
2121
keywordsPath = 'keywords',
2222
}) => {
23-
const section: Section = useAppSelector((state) => get(state.resume, path, {}));
23+
const section: SectionType = useAppSelector((state) => get(state.resume, path, {}));
2424
const dateFormat: string = useAppSelector((state) => get(state.resume, 'metadata.date.format'));
2525
const primaryColor: string = useAppSelector((state) => get(state.resume, 'metadata.theme.primary'));
2626

client/templates/Onyx/widgets/Section.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Email, Link, Phone } from '@mui/icons-material';
2-
import { ListItem, Section } from '@reactive-resume/schema';
2+
import { ListItem, Section as SectionType } from '@reactive-resume/schema';
33
import get from 'lodash/get';
44
import isArray from 'lodash/isArray';
55
import isEmpty from 'lodash/isEmpty';
@@ -20,7 +20,7 @@ const Section: React.FC<SectionProps> = ({
2020
headlinePath = 'headline',
2121
keywordsPath = 'keywords',
2222
}) => {
23-
const section: Section = useAppSelector((state) => get(state.resume, path, {}));
23+
const section: SectionType = useAppSelector((state) => get(state.resume, path, {}));
2424
const dateFormat: string = useAppSelector((state) => get(state.resume, 'metadata.date.format'));
2525
const primaryColor: string = useAppSelector((state) => get(state.resume, 'metadata.theme.primary'));
2626

client/templates/Pikachu/widgets/Section.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Email, Link, Phone } from '@mui/icons-material';
2-
import { ListItem, Section } from '@reactive-resume/schema';
2+
import { ListItem, Section as SectionType } from '@reactive-resume/schema';
33
import get from 'lodash/get';
44
import isArray from 'lodash/isArray';
55
import isEmpty from 'lodash/isEmpty';
@@ -20,7 +20,7 @@ const Section: React.FC<SectionProps> = ({
2020
headlinePath = 'headline',
2121
keywordsPath = 'keywords',
2222
}) => {
23-
const section: Section = useAppSelector((state) => get(state.resume, path, {}));
23+
const section: SectionType = useAppSelector((state) => get(state.resume, path, {}));
2424
const dateFormat: string = useAppSelector((state) => get(state.resume, 'metadata.date.format'));
2525
const primaryColor: string = useAppSelector((state) => get(state.resume, 'metadata.theme.primary'));
2626

0 commit comments

Comments
 (0)