Skip to content

Commit 81c7c8d

Browse files
committed
Fixed darkmode flicker on init
1 parent aea1ae6 commit 81c7c8d

File tree

4 files changed

+23
-10
lines changed

4 files changed

+23
-10
lines changed

docs/_includes/head.html

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,12 @@
1515
<link rel="preconnect" href="https://fonts.googleapis.com">
1616
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
1717
<link href="https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,300..800;1,300..800&display=swap" rel="stylesheet">
18+
19+
<script>
20+
// Immediately apply darkmode styling if relevant to prevent flickering
21+
let currentTheme = localStorage.getItem('theme');
22+
if (currentTheme && currentTheme === 'dark') {
23+
document.documentElement.setAttribute("data-theme", 'dark');
24+
}
25+
</script>
1826
</head>

docs/css/default.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,12 +234,13 @@ table {
234234
border-spacing: 0px;
235235

236236
th, td {
237-
padding: calc(var(--spacing-unit) * 20 * .01) calc(var(--spacing-unit) * .5);
237+
padding: calc(var(--spacing-unit) * 18 * .01) calc(var(--spacing-unit) * .5);
238238
font-size: 0.9em;
239239
}
240240

241241
// Colors
242242
th {
243+
color: var(--table-header-text-color);
243244
background-color: var(--table-header-bg-color);
244245
}
245246

docs/css/dm.scss

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ $dm-brand-color-dark: darken($dm-brand-color, 15%) !default;
1010

1111
$dm-text-color: #d4d3df !default;
1212
$dm-title-color: #eee !default;
13-
$dm-background-color-1: #27272e !default;
13+
$dm-background-color-1: #2b2b32 !default;
1414
$dm-background-color-2: #3e3e48 !default;
1515
$dm-background-color-code: #343640 !default;
1616
$dm-background-color-hover: #dddddd0f !default;
@@ -19,10 +19,11 @@ $dm-link-base-color: lighten($dm-brand-color, 5%) !default;
1919
$dm-link-visited-color: $dm-link-base-color !default;
2020
$dm-link-hover-color: $dm-text-color !default;
2121

22-
$dm-table-header-bg-color: lighten($dm-background-color-1, 10%) !default;
23-
$dm-table-zebra-color-1: lighten($dm-background-color-1, 4%) !default;
24-
$dm-table-zebra-color-2: lighten($dm-background-color-1, 4%) !default;
25-
$dm-table-border-color: #00000014 !default;
22+
$dm-table-header-text-color: $dm-text-color !default;
23+
$dm-table-header-bg-color: lighten($dm-background-color-1, 12%) !default;
24+
$dm-table-zebra-color-1: lighten($dm-background-color-1, 6%) !default;
25+
$dm-table-zebra-color-2: lighten($dm-background-color-1, 4%) !default;
26+
$dm-table-border-color: #00000014 !default;
2627

2728
@mixin darkmode-colors {
2829
--brand-color: #{$lm-brand-color};
@@ -41,6 +42,7 @@ $dm-table-border-color: #00000014 !default;
4142
--link-visited-color: #{$dm-link-visited-color};
4243
--link-hover-color: #{$dm-link-hover-color};
4344

45+
--table-header-text-color: #{$dm-table-header-text-color};
4446
--table-header-bg-color: #{$dm-table-header-bg-color};
4547
--table-zebra-color-1: #{$dm-table-zebra-color-1};
4648
--table-zebra-color-2: #{$dm-table-zebra-color-2};

docs/css/lm.scss

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,11 @@ $lm-link-base-color: $lm-brand-color !default;
1919
$lm-link-visited-color: darken($lm-link-base-color, 15%) !default;
2020
$lm-link-hover-color: $lm-text-color !default;
2121

22-
$lm-table-header-bg-color: lighten($lm-brand-color, 39%) !default;
23-
$lm-table-zebra-color-1: lighten($lm-brand-color, 45%) !default;
24-
$lm-table-zebra-color-2: lighten($lm-brand-color, 47%) !default;
25-
$lm-table-border-color: #00000014 !default;
22+
$lm-table-header-text-color: white !default;
23+
$lm-table-header-bg-color: #555561 !default;
24+
$lm-table-zebra-color-1: darken($lm-background-color-1, 4%) !default;
25+
$lm-table-zebra-color-2: darken($lm-background-color-1, 2%) !default;
26+
$lm-table-border-color: #00000014 !default;
2627

2728
@mixin lightmode-colors {
2829
--brand-color: #{$lm-brand-color};
@@ -41,6 +42,7 @@ $lm-table-border-color: #00000014 !default;
4142
--link-visited-color: #{$lm-link-visited-color};
4243
--link-hover-color: #{$lm-link-hover-color};
4344

45+
--table-header-text-color: #{$lm-table-header-text-color};
4446
--table-header-bg-color: #{$lm-table-header-bg-color};
4547
--table-zebra-color-1: #{$lm-table-zebra-color-1};
4648
--table-zebra-color-2: #{$lm-table-zebra-color-2};

0 commit comments

Comments
 (0)