Skip to content

build refactor patches needed #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
austinvhuang opened this issue Jul 19, 2024 · 1 comment
Closed

build refactor patches needed #19

austinvhuang opened this issue Jul 19, 2024 · 1 comment

Comments

@austinvhuang
Copy link
Contributor

austinvhuang commented Jul 19, 2024

Follow-up to #16 Few issues i'm running into so far:

  • default target for make should be clang/make based and not require cmake
  • cmake 3.28 is a bit high (on my system i have 3.25.1 installed) - what's the lowest we can get away with
  • find argument usage isn't portable, on mac i get the error- find: -executable: unknown primary or operator
  • I think the dollar dereferencing $$exepath might work different on mac, getting /bin/sh: xe_path: command not found errors.
  • all examples should depend on dawnlib and run setup.py automatically if the shared library is not there
  • there seem to be cross dependencies between examples, eg run_hello_world seems to be doing a find for matmul.
@austinvhuang
Copy link
Contributor Author

Reverting for now with 60b1b7d and 45e640d the PR is staged in the dev branch for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant