Skip to content

Consider testing more optimization option variants #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dcodeIO opened this issue Apr 13, 2020 · 1 comment
Closed

Consider testing more optimization option variants #1219

dcodeIO opened this issue Apr 13, 2020 · 1 comment

Comments

@dcodeIO
Copy link
Member

dcodeIO commented Apr 13, 2020

Left the following comment on #1199 not directly affecting that PR, but still deserves an issue on its own :)

I still believe we should somehow test more variations of optimization options, just to make sure we are not missing a branch, since if something goes wrong on a user's end these things will be exceptionally hard to track down. Probably fine to not have fixtures for these, so just compile and run the tests on them.

Background is that there are some static branches in stdlib picking different code paths, like when optimizing for size or speed, that may become more complex than just default opts vs. no opts at all, and at some point we might end up not covering all of them in the test suite.

@dcodeIO
Copy link
Member Author

dcodeIO commented May 27, 2020

Closing this issue as part of 2020 vacuum because we talked about this briefly, and it was mentioned that current static branches should align well with no optimizations and -O3. Let's keep an eye on this and re-open if necessary.

@dcodeIO dcodeIO closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant