Skip to content

Default exports broken #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jtenner opened this issue Apr 14, 2020 · 5 comments
Closed

Default exports broken #1223

jtenner opened this issue Apr 14, 2020 · 5 comments

Comments

@jtenner
Copy link
Contributor

jtenner commented Apr 14, 2020

Minimal repro here: https://webassembly.studio/?f=i7lefl19ym9

Looks like it has to do with the parser treating default exports as regular exports.
@MaxGraey
Copy link
Member

MaxGraey commented May 8, 2020

duplicate: #98

@dcodeIO
Copy link
Member

dcodeIO commented May 8, 2020

The minimal repro there seems to work. Did we do something about that already?

@MaxGraey
Copy link
Member

MaxGraey commented May 8, 2020

Hmm, yeah it seems this already repaired

@MaxGraey MaxGraey removed the duplicate label May 8, 2020
@MaxGraey
Copy link
Member

MaxGraey commented May 9, 2020

Could we close this?

@dcodeIO
Copy link
Member

dcodeIO commented May 9, 2020

Closing, as the initial repro seems to work and #1257 fixes something that seems related. Feel free to reopen if there are still issues :)

@dcodeIO dcodeIO closed this as completed May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dcodeIO @MaxGraey @jtenner